-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT MERGE] Component doc #2339
Conversation
@matentzn would like your eyes on this - wasn't sure how to add general instructions for makefile, not sure if what I wrote is ideal. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent! Lets see whether this is enough for @rays22 to figure it out!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks mostly clear. I have noted where it is not clear to me.
@@ -0,0 +1,44 @@ | |||
# Adding components to an ODK repo | |||
|
|||
To add custom components to an ODK repo, please follow the following steps: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to have an introductory section somewhere before this. What is a component
in this jargon? When and why would you want to use such components in your ontology?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have added in docs to do to add an explainer about components
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nvm i see that it is in the docs already
``` | ||
components: | ||
products: | ||
- filename: your-component-name.owl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there any file naming conventions that we should follow here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure on this - @matentzn?
docs/add-components.md
Outdated
Import(<http://purl.obolibrary.org/obo/uberon/components/your-component-name.owl>) | ||
``` | ||
5. Refresh your repo by running `sh run.sh make update_repo` - this should create a new file in src/ontology/components. | ||
6. In your custom makefile (src/ontology/uberon.Makefile) add a goal for your custom make file as follows: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this part needed when adding a component that uses a ROBOT template?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you need to add a goal, but the goal would the robot template - will make this more clear. Thanks :)
moved to ODK jinja docs INCATools/ontology-development-kit#577 |
Docs for component
Adding it as a draft PR for UBERON for now, will generalise it in jinja once @rays22 gives feedback