Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Component doc #2339

Closed
wants to merge 8 commits into from
Closed

[DO NOT MERGE] Component doc #2339

wants to merge 8 commits into from

Conversation

shawntanzk
Copy link
Collaborator

Docs for component
Adding it as a draft PR for UBERON for now, will generalise it in jinja once @rays22 gives feedback

@shawntanzk shawntanzk added the tech label Mar 7, 2022
@shawntanzk shawntanzk self-assigned this Mar 7, 2022
@shawntanzk
Copy link
Collaborator Author

@matentzn would like your eyes on this - wasn't sure how to add general instructions for makefile, not sure if what I wrote is ideal.

docs/add-components.md Outdated Show resolved Hide resolved
docs/add-components.md Outdated Show resolved Hide resolved
docs/add-components.md Outdated Show resolved Hide resolved
docs/add-components.md Outdated Show resolved Hide resolved
Copy link
Contributor

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Lets see whether this is enough for @rays22 to figure it out!

Copy link
Collaborator

@rays22 rays22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks mostly clear. I have noted where it is not clear to me.

@@ -0,0 +1,44 @@
# Adding components to an ODK repo

To add custom components to an ODK repo, please follow the following steps:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to have an introductory section somewhere before this. What is a component in this jargon? When and why would you want to use such components in your ontology?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have added in docs to do to add an explainer about components

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm i see that it is in the docs already

```
components:
products:
- filename: your-component-name.owl
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any file naming conventions that we should follow here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure on this - @matentzn?

Import(<http://purl.obolibrary.org/obo/uberon/components/your-component-name.owl>)
```
5. Refresh your repo by running `sh run.sh make update_repo` - this should create a new file in src/ontology/components.
6. In your custom makefile (src/ontology/uberon.Makefile) add a goal for your custom make file as follows:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this part needed when adding a component that uses a ROBOT template?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to add a goal, but the goal would the robot template - will make this more clear. Thanks :)

@shawntanzk
Copy link
Collaborator Author

moved to ODK jinja docs INCATools/ontology-development-kit#577

@shawntanzk shawntanzk closed this Mar 16, 2022
@anitacaron anitacaron deleted the component-doc branch April 11, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants