Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new inSubset ROBOT template #2196

Merged
merged 12 commits into from
Mar 17, 2022
Merged

Add a new inSubset ROBOT template #2196

merged 12 commits into from
Mar 17, 2022

Conversation

rays22
Copy link
Collaborator

@rays22 rays22 commented Nov 26, 2021

This commit intends to add a new inSubset ROBOT template.
This commit is related to #2127 (comment) .

This commit intends to add a new `inSubset` ROBOT template.
This commit is related to #2127 (comment) .
@rays22 rays22 requested a review from matentzn November 26, 2021 19:54
@rays22 rays22 self-assigned this Nov 26, 2021
@dosumis
Copy link
Contributor

dosumis commented Feb 11, 2022

I think this would work nicely. We need to delete the example before merging though. Also @nicolevasilevsky what AP are we now using for linking to tickets dc:source or rdfs:seeAlso ? (seems like something should have in our new centralised editor's guide).

Copy link
Contributor

@dosumis dosumis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Activating template will also require adding OWL file it produces to components + import statement on uberon-edit.owl

src/templates/in-subset.template.tsv Outdated Show resolved Hide resolved
@dosumis dosumis added the tech label Feb 11, 2022
@matentzn
Copy link
Contributor

@rays22 can you finish and merge this PR?

@rays22
Copy link
Collaborator Author

rays22 commented Mar 2, 2022

Activating template will also require adding OWL file it produces to components + import statement on uberon-edit.owl

@dosumis ,
Do I need to do that before merging?

@matentzn
Copy link
Contributor

matentzn commented Mar 2, 2022

Best put this PR on our meeting agenda and I will tell you how to create a ROBOT template component with ODK!

@nicolevasilevsky
Copy link
Member

we use rdfs:seeAlso in Mondo

@shawntanzk
Copy link
Collaborator

  1. Create new component
  2. Have component dependent on tsv template
  3. component = template cmd that turns template into owl

@shawntanzk to point @rays22 to docs and fix up docs whie at it

@shawntanzk
Copy link
Collaborator

Currently doesnt seem like there is documentation on components - @shawntanzk to work on documentation for this

@shawntanzk
Copy link
Collaborator

docs: #2339

@rays22
Copy link
Collaborator Author

rays22 commented Mar 15, 2022

linking to tickets dc:source or rdfs:seeAlso

FYI: This template uses oio:source instead of rdfs:seeAlso for provenance at the annotation level as discussed here:
#2108 (comment)

- add OWL file it produces to components
- add import statement on uberon-edit.obo
- add other related updates
- fix superfluous spaces in uberon-odk.yaml file
- add OWL file it produces to components
@rays22 rays22 requested a review from shawntanzk March 16, 2022 16:22
@shawntanzk
Copy link
Collaborator

@rays22 I'm a bit confused, the tsv you added is for inSubset, but you activated in-taxon template?

@shawntanzk
Copy link
Collaborator

shawntanzk commented Mar 16, 2022

@rays22 you need to run sh run.sh make update_repo after the change in the yaml file

src/ontology/components/in-taxon.owl Outdated Show resolved Hide resolved
docs/odk-workflows/RepositoryFileStructure.md Outdated Show resolved Hide resolved
Copy link
Contributor

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry in-subset.owl not in-taxon.owl.

@rays22 rays22 merged commit 033b4d7 into master Mar 17, 2022
@rays22 rays22 deleted the issue2127t branch March 17, 2022 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

5 participants