Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refining the Uberon Euarchontoglires subset -- part 2 #2127

Closed
1 task done
rays22 opened this issue Oct 25, 2021 · 9 comments
Closed
1 task done

Refining the Uberon Euarchontoglires subset -- part 2 #2127

rays22 opened this issue Oct 25, 2021 · 9 comments
Assignees
Labels
autoclosed-unfixed This issue has been closed automatically. HCA Human Cell Atlas Stale

Comments

@rays22
Copy link
Collaborator

rays22 commented Oct 25, 2021

Remaining tasks

UBERON:4x --> mixed, I think this is a small enough subset to look over quickly and add TCs. There will be a handful applicable to human"

Originally posted by @rays22 in #2050 (comment)

@paolaroncaglia
Copy link
Contributor

paolaroncaglia commented Oct 25, 2021

@matentzn @rays22 cc @dosumis
Now that the ~1772 taxon constraints added in #2050 are in Uberon, could someone please re-build the Euarch slim? (The old one was at https://github.com/obophenotype/uberon/blob/v2021-07-27/subsets/euarchontoglires-basic.owl.) Many thanks!

Note to self:

  • When revised slim is ready, discuss its import into the HCAO pipeline with Zoe

@paolaroncaglia
Copy link
Contributor

paolaroncaglia commented Oct 25, 2021

Summing up the tasks we resolved to leave for a “second pass” at the Euarch slim:

  • Need to refine the UBERON:4x series in https://docs.google.com/spreadsheets/d/133F9PVxOk2lM8tkY_afjy7P_bwbZM1b_u1O2abyTvI8/edit#gid=1223601784
    @cmungall wrote: “UBERON:4x --> mixed, I think this is a small enough subset to look over quickly and add TCs. There will be a handful applicable to human"
    There are 369 non-obsolete UBERON:4x classes in the slim, copied in the spreadsheet above. I inspected 10 random terms among the 369, and at least 3 are applicable to human, so I'm not very comfortable with adding TCs en masse to this set. Is there someone who could take a closer look and advice on what terms are safe to restrict to never in mammals? Perhaps Wasila, who authored some terms in this set?

  • Terms that were added TCs in Refining the Uberon Euarchontoglires subset #2050 may be scanned for FMA xrefs, and brought back into the slim if they have FMA xrefs.

  • Are there any logically defined non-human terms left? Search for annotation property ‘never in taxon’ ‘Homo sapiens’ (e.g. ‘ampullary gland’, ‘bone of reproductive organ’). Some terms may need double-checking in case they are found in non-human Euarchontoglires.

  • Are there any insect terms left? Insect terms may be retrieved by searching for database_cross_reference contains FBbt (e.g.: 'egg chorion’). This will also bring up a dozen terms whose label contains “insect” (e.g. 'insect ring gland’).

  • (Moved to Candidates for taxon restrictions #2194) Are the following random finds left?
    exoskeleton
    shell
    'open circulatory system'
    feather
    rhinarium?
    honey

  • (Moved to Candidates for taxon restrictions #2194; 2x, 3x, 4x and 6x terms are addressed elsewhere) Are any terms left to check/add TCs from this list? (It comes from Human subset uberon 0 byte file? #1824)

Notes to self:
Guidelines on adding TCs here.
Jim Balhoff wrote "You all may find my OBO taxon constraints plugin for Protégé useful in seeing what effective taxon constraint the reasoner knows about for the selected term (and you can get explanations). Just keep in mind that it can be SLOW.”

rays22 added a commit that referenced this issue Nov 11, 2021
This commit intends to add a conservative set of taxon constraints to some of the 2x classes.
This PR is related to #2127 and
the discussion [here.](#2158 (reply in thread))
rays22 added a commit that referenced this issue Nov 11, 2021
This commit intends to add a conservative set of taxon constraints to some of the 2x classes.
This PR is related to #2127 and
the discussion [here.](#2158 (reply in thread))
@paolaroncaglia
Copy link
Contributor

Update: the broader issue of taxon restrictions was discussed at the Uberon editors meeting on 22/11/21:

"We need more specific action items to deal with taxon stuff
#2137
Chris suggested fix - Chris to add ticket!
Roll back 2x, 3x, 4x general taxon constraint
2x, 3x, 4x all get new slim tag - used for anti-slim stripping of terms only with owltools. Curate to hold back a few.
Suggestion:
We need a taxon fix hackathon where we look at the ontology itself to work through a longer term strategy for fixing."

@matentzn
Copy link
Contributor

matentzn commented Nov 26, 2021

Alright, this is how I understand this ticket.

  • "Roll back": We go to @rays22 original list of taxon constraints, and remove them using robot unmerge, and instead add a "never_in_euroglires" subset tag on them. EDIT: remove all 3x terms, keep the 6x ones as these are likely to be totally fine.
  • Create another ROBOT template with the 3x terms and a new column "AI oboInOwl:inSubset"
  • "Anti-slim stripping". After the normal unsat-pipeline is run, we use SPARQL to remove the remaining "never_in_euroglires", the difficulty here is to tie together broken existential edges (i.e. part-of) edges. Maybe we can use some kind of Relationgraph style approach or something @cmungall outline in Add anti-slims for various taxonomic groupings #2183.

@rays22
Copy link
Collaborator Author

rays22 commented Nov 26, 2021

  • "Roll back": We go to @rays22 original list of taxon constraints, and remove them using robot unmerge, and instead add a "never_in_euroglires" subset tag on them.

Summary of 673 taxon constraints added as part of #2050

Here is my list of the #2050-related taxon constraints that are in UBERON currently.

  • provenance: {source="https://github.com/obophenotype/uberon/issues/2050"}

  • 660 classes : never_in_taxon-IDs.txt relationship: never_in_taxon NCBITaxon:n

    • 23 classes : UBERON:2x (likely Teleost)
    • 637 classes : UBERON:3x (likely Amphibia)
  • 13 classes : UBERON:6x (Arthropods) relationship: in_taxon NCBITaxon:6656 {source="https://github.com/obophenotype/uberon/issues/2050"} ! Arthropoda

rays22 added a commit that referenced this issue Nov 26, 2021
This commit intends to
roll back the 3x taxon constraints that were part of this ticket.
The bulk addition of taxon constraints appear to include classes that clash with classes that genuinely overlap with *Mammalia*.
See #2127 (comment) .
If applied, this commit will fix #2050.
rays22 added a commit that referenced this issue Nov 26, 2021
This commit intends to add a new `inSubset` ROBOT template.
This commit is related to #2127 (comment) .
@paolaroncaglia paolaroncaglia removed their assignment Feb 24, 2022
rays22 added a commit that referenced this issue Mar 17, 2022
* Add a new inSubset ROBOT template

This commit intends to add a new `inSubset` ROBOT template.
This commit is related to #2127 (comment) .

* Delete example line

* Activate template

- add OWL file it produces to components
- add import statement on uberon-edit.obo
- add other related updates
- fix superfluous spaces in uberon-odk.yaml file

* Activate template

- add OWL file it produces to components

* Fix incorrect product filename.

* Update repo

* Update incorrect owl filename

* Remove in-taxon references

* Re-import in-subset.owl

* Replace four spaces with a tab in uberon.Makefile
    * This syntax error had caused problems.
@github-actions
Copy link

This issue has not seen any activity in the past 6 months; it will be closed automatically in one year from now if no action is taken.

@github-actions github-actions bot added the Stale label May 29, 2022
@paolaroncaglia
Copy link
Contributor

This is still in progress.

@github-actions github-actions bot removed the Stale label May 31, 2022
@github-actions
Copy link

github-actions bot commented Feb 8, 2023

This issue has not seen any activity in the past 6 months; it will be closed automatically one year from now if no action is taken.

@github-actions github-actions bot added the Stale label Feb 8, 2023
Copy link

github-actions bot commented Feb 9, 2024

This issue has been closed automatically because it has not been updated in 18 months. Please re-open if you still need this to be addressed.

@github-actions github-actions bot added the autoclosed-unfixed This issue has been closed automatically. label Feb 9, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autoclosed-unfixed This issue has been closed automatically. HCA Human Cell Atlas Stale
Projects
Status: Done
Development

No branches or pull requests

3 participants