Adding domain-range constraints for located_in, see #255 #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
note this changes introduces a spurious diff bringing in AP declarations, this can be ignored
|
Hi Chris, Barry asked that I have a quick look at this. In the new axiomatization, located_in is (independent continuant other than spatial region) -> (independent continuant other than spatial region). For relating to spatial regions, the relation is occupies-spatial-region and is (independent-continuant other than spatial region) -> spatial region. There is no location relation from spatial region to spatial region. In that case part-of is the appropriate relation. |
cmungall
added a commit
that referenced
this pull request
Sep 28, 2018
We keep the weaker D+R constraints in for EL purposes
|
Thanks - I'm taking care of these on this PR: #261 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
note this changes introduces a spurious diff bringing in
AP declarations, this can be ignored