Ready to merge: Domain and range constraints #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cmungall
commented
Sep 26, 2018
•
cmungall
commented
- Adds multiple new domain and range constraints
- Brings in more external classes (still need to refactor import generation)
- Adding more obo foundry unique labels
- Adding additional metadata / AAs
cmungall
changed the title
cmungall
requested review from
dosumis,
balhoff,
jamesaoverton and
mbrush
and removed request for
dosumis
There was a problem hiding this comment.
I looked at the changes to the Makefile and ran make and make test. There's a lot of noise but it seemed to work. Then I checked ro.owl in Protege with ELK. Things look reasonable. The only significant problem I see is that GO_0004872 and GO_0048018 are under owl:Thing without labels.
The Makefile just calls robot for most things, which might not refer to the fetched robot.jar. Would ./robot be better?
|
I don't think the GO orphan issues were introduced with this PR, but this is a good time to fix this. robot: I've always used the robot on the path. We should switch the .travis.yml to use the odk docker container |
We keep the weaker D+R constraints in for EL purposes
…eneral 'anatomical structure' Broadening range for some developmental relations to AS. See obophenotype/uberon#1455
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.