Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename "exposure event or process" to "exposure of organism" (issue 599) #606

Merged
merged 14 commits into from
Feb 9, 2024

Conversation

wdduncan
Copy link
Collaborator

@wdduncan wdduncan commented May 2, 2022

  • add exposure event class
  • change domain of 'related via exposure to' to 'exposure event'
  • obsolete 'exposure event or process'

@wdduncan
Copy link
Collaborator Author

wdduncan commented May 2, 2022

Fixes #599

@matentzn @diatomsRcool @laurenechan @cmungall The goal of this PR is to fix the confusion created by having both exposure event and exposure event or process classes in ECTO.

It also relates to COB issue OBOFoundry/COB#192.
If COB mints a new IRI for exposure event, we may need to obsolete this class.

Copy link
Contributor

@cmungall cmungall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We recommend the ECTO group mint an ID for exposure event for now, with the understanding it may be deprecated and replaced by a COB class eventually

We will then replace the usage of the current RO class in domains and ranges with the ECTO URI (and later with the COB URI)

@wdduncan
Copy link
Collaborator Author

COB has added the class exposure of organism (PR).
The class has not been added to a COB release (i.e., it is only in cob-edit.owl). I've submitted an issue concerning when COB will create a release.

@wdduncan wdduncan changed the title rename "exposure event or process" to "exposure event" (issue 599) rename "exposure event or process" to "exposure of organism" (issue 599) Aug 18, 2022
@wdduncan
Copy link
Collaborator Author

wdduncan commented Nov 1, 2022

@cmungall This is being held up b/c we are waiting on new release of COB. Are you the only one who release COB? Can you assign some else?

@github-actions
Copy link
Contributor

This PR has not seen any activity in 90 days and has been marked as stale. If it is no longer needed, please close the PR. Otherwise, please update the PR with a status update.

@github-actions github-actions bot added the stale label Jan 31, 2023
@wdduncan
Copy link
Collaborator Author

Update: The COB class needed is ready. I just need to find the time to circle back to this.

@wdduncan wdduncan removed the stale label Jan 31, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2023

This PR has not seen any activity in 90 days and has been marked as stale. If it is no longer needed, please close the PR. Otherwise, please update the PR with a status update.

@wdduncan
Copy link
Collaborator Author

@anitacaron I've been holding of on this until the COB is ready so that I can use the COB class.

@anitacaron
Copy link
Collaborator

@wdduncan, Do you need help fixing the conflicts in the ro-edit.owl?

@wdduncan
Copy link
Collaborator Author

@anitacaron I don't think there will be any conflicts (I hope).
Now that exposure of organism is in COB, I think I just need to change the IRI for exposure event or process (and label) to match the COB class (which currently not in RO).

@anitacaron
Copy link
Collaborator

There's already a conflict in this branch, but I'll wait for you to add the COB term. Do you need help importing COB?

@anitacaron anitacaron linked an issue Jun 12, 2023 that may be closed by this pull request
@github-actions github-actions bot removed the stale label Jun 13, 2023
@wdduncan
Copy link
Collaborator Author

Just an update:
Waiting on #717 to complete before continuing on this. That PR has a COB import file that I will used to add the necessary class.

@anitacaron
Copy link
Collaborator

COB is already ready to use. It was merged in PR #736. I can fix the conflict in the edit file.

@wdduncan
Copy link
Collaborator Author

COB is already ready to use. It was merged in PR #736. I can fix the conflict in the edit file.

@anitacaron Your help would be greatly appreciated! :)

@github-actions
Copy link
Contributor

This PR has not seen any activity in 90 days and has been marked as stale. If it is no longer needed, please close the PR. Otherwise, please update the PR with a status update.

@github-actions github-actions bot added the stale label Oct 16, 2023
@wdduncan
Copy link
Collaborator Author

This has been open for quite a while. I need to review to see what needs to be done in order to finish.

@github-actions github-actions bot removed the stale label Oct 17, 2023
@wdduncan
Copy link
Collaborator Author

Still working on this.

@wdduncan
Copy link
Collaborator Author

wdduncan commented Nov 6, 2023

We recommend the ECTO group mint an ID for exposure event for now, with the understanding it may be deprecated and replaced by a COB class eventually

We will then replace the usage of the current RO class in domains and ranges with the ECTO URI (and later with the COB URI)

@anitacaron @cmungall The IRI has been changed to COB_0001000 (from COB). Can we move forward now.

Copy link
Collaborator Author

@wdduncan wdduncan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Label and IRI has been updated. Old creator annotation has been removed.
Can finish this up?

src/ontology/ro-edit.owl Outdated Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Feb 6, 2024

This PR has not seen any activity in 90 days and has been marked as stale. If it is no longer needed, please close the PR. Otherwise, please update the PR with a status update.

@github-actions github-actions bot added stale and removed stale labels Feb 6, 2024
src/ontology/imports/cl_import.owl Outdated Show resolved Hide resolved
Copy link
Collaborator

@anitacaron anitacaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically, it's approved. It still needs an ontology review.

Copy link
Contributor

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anitacaron anitacaron dismissed cmungall’s stale review February 9, 2024 16:22

Previous review from May 2022 was to hold this PR until COB term is available. I confirm the COB term was imported correctly in this PR.

@anitacaron anitacaron merged commit 3428cae into master Feb 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rename "exposure event or process" to "exposure of organism"
4 participants