Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE YET First pass at #68 making a ro-chado subset #95

Merged
merged 2 commits into from
Jun 14, 2016

Conversation

cmungall
Copy link
Contributor

@cmungall cmungall commented Dec 8, 2015

@kimrutherford
Copy link

ro-chado.obo is quite a bit smaller than the ro.obo in the master branch

Looks like that's due to --remove-tbox so please ignore that.

@cybersiddhu
Copy link

cybersiddhu commented Jun 13, 2016

FYI,
I have to make few minor changes to make it work ...

Anyway, are you planning to merge your changes from this branch(not my fork) to master.

@kimrutherford
Copy link

We have used ro-chado.obo to do a full load of Chado for PomBase and it all looks fine. So the next PomBase release will be based in it.

@cybersiddhu
Copy link

Nice work kim, great to know that.

Chris,
Are you thinking about doing any merge or you expect more work need to be done.

@cmungall
Copy link
Contributor Author

Sounds like we should merge

@cybersiddhu - do you want to to merge first, then you make a PR with yr changes (which look fine)

@cmungall cmungall merged commit 4db6769 into master Jun 14, 2016
kimrutherford added a commit to pombase/pombase-legacy that referenced this pull request Jun 14, 2016
cmungall added a commit that referenced this pull request Jun 15, 2016
@cmungall
Copy link
Contributor Author

in latest release, https://github.com/oborel/obo-relations/releases/tag/v2016-06-15

The PURL is
http://purl.obolibrary.org/obo/ro/subsets/ro-chado.obo

@cybersiddhu can you make a new PR with your changes?

Should we announce on GMOD?

@cybersiddhu
Copy link

Chris,
Thanks for the release.
One of my commit removes the OBO_REL backward compatibility, so i will skip that one.
Yes it should be announced to GMOD list, should be a good time as gmod meeting is very close. More people might try it out and get more feedback.

cmungall added a commit that referenced this pull request Aug 23, 2016
cmungall added a commit that referenced this pull request Aug 23, 2016
@Clare72 Clare72 deleted the ro-for-chado branch October 7, 2019 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants