-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove is_a from ro-chado.obo #115
Conversation
@cybersiddhu @kimrutherford comments? The fake is-a relation was added specifically to support chado, as discussed in #68 |
It won't be a problem for us. We'll load is_a separately if needed. |
I find it hard to believe that is_a is actually causing the problem @abretaud is describing. I'll discuss over on their tripal tracker. |
Yes, the |
OK, we should move forward. The fix needs to be in the perl script though rather than derived file, see #119 |
Do you mean #119 fixed the problem or not? This can be closed if it's the case |
I merged it, but also did #121 to ensure future releases don't include the fake isa |
Great, thank you! |
Hum, the fake is_a was reintroduced in this commit: fc42248 |
Yes it was intended. In fact ro-chado was originally created to provide But those who need the fake stanza can add it separately, at it seems On 29 Aug 2016, at 6:32, Anthony Bretaudeau wrote:
|
Ok, that's what I understood too, but the fake stanza is back in the latest revision |
Oh, sorry I misunderstood. You are quite right. The last release contained an older version of ro-chado. The release Makefile now ensures that this is made as in sync with each release. I'll make a new release shortly |
Hum, are you still thinking about the new release? (No hurry at all, just in case you forgot about it) |
Permanent URL for this release: http://purl.obolibrary.org/obo/ro/releases/2016-09-02/subsets/ro-chado.obo PURL for latest: |
Awesome, thank you ! |
It looks like the name of the slim/subset is not being persisted in the On 2 Sep 2016, at 13:11, Anthony Bretaudeau wrote:
|
Ok, yes, I think it should be ok like that |
As discussed in galaxy-genome-annotation/docker-tripal#6, we have a problem loading ro-chado.obo in chado.
It looks like removing "OBO_REL:is_a" from ro-chado fixes the problem.