Skip to content

Commit

Permalink
fix(otelcol) prometheus metrics export descriptions (open-telemetry#1120
Browse files Browse the repository at this point in the history
)

* fix prom metrics export descriptions

Signed-off-by: Pierre Tessier <pierre@pierretessier.com>

* fix prom metrics export descriptions

Signed-off-by: Pierre Tessier <pierre@pierretessier.com>

---------

Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
Co-authored-by: Juliano Costa <julianocosta89@outlook.com>
  • Loading branch information
2 people authored and Dylan Myers committed Sep 19, 2023
1 parent cf423e0 commit e8de8b0
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 7 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ release.
([#1114](https://github.com/open-telemetry/opentelemetry-demo/pull/1114))
* [cartservice] update .NET package to 1.6.0 release
([#1115](https://github.com/open-telemetry/opentelemetry-demo/pull/1115))
* Set metric description to blank for rpc.server.duration and queueSize
([#1120](https://github.com/open-telemetry/opentelemetry-demo/pull/1120))
* sluggify Grafana dashboard name
([#1121](https://github.com/open-telemetry/opentelemetry-demo/pull/1121))

Expand Down
18 changes: 11 additions & 7 deletions src/otelcollector/otelcol-config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,16 @@ exporters:

processors:
batch:
filter:
metrics:
exclude:
match_type: strict
metric_names:
- queueSize
transform:
metric_statements:
- context: metric
statements:
# FIXME: remove this when this is issue is resolved: https://github.com/open-telemetry/opentelemetry-java/issues/4834
- set(description, "") where name == "queueSize"
# FIXME: remove this when the following 2 issues are resolved
# Java: https://github.com/open-telemetry/opentelemetry-java-instrumentation/issues/9478
# Go: https://github.com/open-telemetry/opentelemetry-go-contrib/issues/4301
- set(description, "") where name == "rpc.server.duration"

connectors:
spanmetrics:
Expand All @@ -35,7 +39,7 @@ service:
exporters: [logging, spanmetrics]
metrics:
receivers: [otlp, spanmetrics]
processors: [filter, batch]
processors: [transform, batch]
exporters: [logging]
logs:
receivers: [otlp]
Expand Down

0 comments on commit e8de8b0

Please sign in to comment.