Merge pull request #261 from ontoportal-lirmm/pr/fix/response-error-h…

…andeling Fix: ontology delete response error handelling
ontoportal-lirmm · Apr 6, 2023 · f344969 · f344969
2 parents bb81ec4 + 00c0626
commit f344969
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/app/controllers/admin_controller.rb b/app/controllers/admin_controller.rb
@@ -273,7 +273,7 @@ def _process_ontologies(success_keyword, error_keyword, process_proc)
 
           if ontology
             error_response = self.send(process_proc, ontology, params)
-            if error_response
+            if response_error?(error_response)
               errors = response_errors(error_response) # see application_controller::response_errors
               _process_errors(errors, response, false)
             else

diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb
@@ -196,7 +196,7 @@ def response_errors(error_struct)
   end
 
   def response_success?(response)
-    return false if response.nil?
+    return true if response.nil?
 
     if response.respond_to?(:status) && response.status
         response.status.to_i < 400