Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Update concepts design #261

Merged
merged 6 commits into from
Jun 7, 2023

Conversation

Bilelkihal
Copy link
Collaborator

@Bilelkihal Bilelkihal commented Jun 2, 2023

Problems

  • Bad styling

What I did

  • Update the styling

Todo

  • Don't show narrower
  • Update the display of the links (make in wrap in the same line)

Screenshots

Before
image

After
new concepts

@Bilelkihal Bilelkihal added the enhancement New feature or request label Jun 2, 2023
@Bilelkihal Bilelkihal self-assigned this Jun 2, 2023
@@ -2,7 +2,7 @@
= hidden_field object_name, :ontology, value: acronym
= hidden_field object_name, :id, value: submissionId
%div#general-card.mt-4
= metadata_section('general', 'General', collapsed: false) do
= metadata_section('general', 'General', collapsed: false) do |c|
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this change, do you use the |c| after

@syphax-bouazzouni
Copy link
Collaborator

Added:

  • add concept details JSON link (ffb1b2b)
  • wrap concept details links values (e01fecb)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants