Merge to master: Release 3.0.0 #753
Open
+641
−286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* simplify the header component to use content instead of a new section * update dropdown component to a custom title section instead of text * update browse page to use Dropdown component not bootsrap one * add color option to square badge component * add text and bg colors options to ontology browse card component * add federation helper code and config sample * add portals filters in the browse page * use federation helpers to get federation ontologies information * remove the filter using index code from submission filter as no used * refactor the filter_using_data function to be faster by using an hash * update the browse analytics cache to change depending on portals * add categories and groups ids on hover to know its origin when federated * use the last part of ids for browse counts independently of its origin * remove binding.pry from final federation code * add an error message if one of the external portal is down * remove $FEDERATED_PORTALS and use existent $PORTALS_INSTANCES variable * handle the merging of the same ontology from different portals * fix groups and categories selection at browse page init
* add portal configuration action and view to home controller * create portal_config_tooltip helper and use in homepage portals section * enhance portal config home section style --------- Co-authored-by: Bilel KIHAL <kb_kihal@esi.dz>
…ookie banner (#760) * Add language-specific anchors to footer section links * Add language-specific anchors to the cookie banner * Refactor language-specific anchors to use I18n default option * Remove anchors from bioportal_config_env.rb.sample; now handled by footer view
syphax-bouazzouni
assigned syphax-bouazzouni and Bilelkihal and unassigned syphax-bouazzouni
…, Instances, Schemes, and Collections (#754) * limite taxonomy card ontologies chips number and add a see all button * Properties layout harmonization * Instances layout harmonization * fix: resolve issues related to properties raised in code review * fix: resolve issues related to instances raised in code review * adding subtab "Details" and API cotextual button to `Schemes` * adding subtab "Details" and API cotextual button to `Collections` * Using unless instead of if in sections controllers * Adding new section tab component and using it in Properties, Instances, Schemes and Collections * display first scheme if none are selected * move the created tabs_section component to rails helpers * fix schemes and collections shows not selecting the right object * remove details partials moving the content directly to the show files * remove unnecessary call in the properties show to find the ontology * use the correct partial in the schemes controller show action * put the tab item helper in the component helpers as generic * use the correct collection partial in the show action * remove unnecessary local in the instances partial * clean instance show partial code * remove unnecessary locals in the properties partial call * remove unnecessary locals in the collections show partial call * remove unnecessary locals in the schemes show partial call * Add presence check (not nil and not empty) for ontology details component before rendering --------- Co-authored-by: Syphax bouazzouni <gs_bouazzouni@esi.dz> Co-authored-by: Bilel KIHAL <kb_kihal@esi.dz>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| - unless types.empty? | ||
| - t.add_row({ th: t('instances.type') }) do |r| | ||
| - r.td do | ||
| = types.map { |cls| link_to_class(@ontology.acronym, cls) }.join(', ').html_safe |
Check notice
Code scanning / Brakeman
Unescaped parameter value. Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Detailssub-tab and API cotextual button in Properties, Instances, Schemes, and Collections #754Backend changes