Feature: Add Details sub-tab and API cotextual button in Properties, Instances, Schemes, and Collections

[muhammedBkf]

Context

Resolve #706, by adding details sub-tab and API contextual button in Properties, Instances, Schemes, and Collections views

Changes

• Adopted same layout as in Classes (Details as a 1st sub-tab)
• Adding in the right the API cotextual button.

367313189-e70e8a14-8cdb-4a6e-8d0d-3221ee37e2c9.mp4

[syphax-bouazzouni]

I see that you are a fast learner, good job on already undersanting our code.

I have reviewed the code, see the request changes bellow (or in the Files changed section), in addition to properties and instances, it need to be done also for collections and schemes.

Regading the pull request formating, here are some our required best practices:

• The naming: if feature start by Feature: your title , if a fix start by Fix: your title .
• The target branch: if feature or fix, open against the branch development, else if a hot fix open against the branch master.
• The PR description: As context put the link to the issue that the PR resolves, add a small desctiption if needed, than list all the changes, with a screen shot of each of them.

Here a documentation of how we work for more details

[muhammedBkf]

Thank you for the review @syphax-bouazzouni, i'll be working on your suggestions

[Bilelkihal]

@muhammedBkf
Good job 👏.
Here's some remarks:
No need to start your commit message with "fix:" or other prefixes. Instead, aim to write concise, clear commit messages that accurately describe what you did.
Also, try to create a separate commit for each change. For example, using a message like "fix: resolve issues related to properties raised in code review" may not be very helpful when looking back at the commit history. It's much clearer if you commit each fix individually.

For pull requests, though, our practice is to begin the title with "Feature: ..." or "Fix: ...".

[muhammedBkf]

Thank you @Bilelkihal

It's just that the commits are in the same PR and the new ones are meant to fix my first commits, that's why the last comments are a bit generic, i will take that into consideration for the upcoming contributions.

[syphax-bouazzouni]

Good work @muhammedBkf,

I took this occasion to do also a global cleaning of our duplicate code and files, see my commits for details. You can test the code again, and if everything is OK, you can squash this PR.

[muhammedBkf]

An error get triggred when an empty string is passed by ontology controller.
Ex: if get_scheme(@ontology, scheme_id) returns an empty string

bioportal_web_ui/app/controllers/ontologies_controller.rb

Lines 192 to 195 in 70bab99

	def schemes
	@schemes = get_schemes(@ontology)
	scheme_id = params[:schemeid] || @submission_latest.URI || nil
	@scheme = scheme_id ? get_scheme(@ontology, scheme_id) : @schemes.first

fixed in this commit

[muhammedBkf]

I didn't get what does @submission_latest.URI do here

bioportal_web_ui/app/controllers/ontologies_controller.rb

Line 194 in 70bab99

scheme_id = params[:schemeid] || @submission_latest.URI || nil

• get_scheme(@ontology, @submission_latest.URI) always returns an empty string even though an ontology have a scheme.
• if we browse to AGROVOC schemes section for example, nothing gets rendered because params[:schemeid] is nil and get_scheme(@ontology, @submission_latest.URI) returns nil too, unlike other sections like properties that renders the first property.

[syphax-bouazzouni]

I didn't get what does @submission_latest.URI do here

bioportal_web_ui/app/controllers/ontologies_controller.rb

Line 194 in 70bab99

scheme_id = params[:schemeid] || @submission_latest.URI || nil

* `get_scheme(@ontology, @submission_latest.URI)`  always returns an empty string even though an ontology have a scheme.

* if we browse to [AGROVOC schemes section](https://agroportal.lirmm.fr/ontologies/AGROVOC?p=schemes) for example, nothing gets rendered because `params[:schemeid]` is nil and `get_scheme(@ontology, @submission_latest.URI)` returns nil too, unlike other sections like `properties` that renders the first property.

in @submission_latest.URI is saved the main scheme id (the default one) is, you can check it with https://stageportal.lirmm.fr/ontologies/INRAETHES?p=schemes, INRAE thesaurus is selected by default because its ID(URI) is set as default in the @submission_latest.URI

[muhammedBkf]

I didn't get what does @submission_latest.URI do here

bioportal_web_ui/app/controllers/ontologies_controller.rb

Line 194 in 70bab99

scheme_id = params[:schemeid] || @submission_latest.URI || nil

* `get_scheme(@ontology, @submission_latest.URI)`  always returns an empty string even though an ontology have a scheme.

* if we browse to [AGROVOC schemes section](https://agroportal.lirmm.fr/ontologies/AGROVOC?p=schemes) for example, nothing gets rendered because `params[:schemeid]` is nil and `get_scheme(@ontology, @submission_latest.URI)` returns nil too, unlike other sections like `properties` that renders the first property.

in @submission_latest.URI is saved the main scheme id (the default one) is, you can check it with https://stageportal.lirmm.fr/ontologies/INRAETHES?p=schemes, INRAE thesaurus is selected by default because its ID(URI) is set as default in the @submission_latest.URI

I get it now! Thank you

[syphax-bouazzouni]

Deployed in https://stageportal.lirmm.fr