Skip to content

Commit

Permalink
remove deprecations from 0.14.0 and before (oscar-system#3358)
Browse files Browse the repository at this point in the history
* remove deprecations from 0.14.0 and before

* remove more old deprecations

these functions were deprecated in oscar-system#2980 (long before 0.14.0) but slightly in the wrong location in the file

* re-add ne and nv alias

* remove obsolete exports

* fix deprecated usage of MPolyQuoLocalizedRing -> MPolyQuoLocRing

* add explanation for ne and nv
  • Loading branch information
benlorenz authored and ooinaruhugh committed Feb 15, 2024
1 parent 5efe318 commit d9ff9dc
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 616 deletions.
6 changes: 3 additions & 3 deletions src/Rings/mpolyquo-localizations.jl
Original file line number Diff line number Diff line change
Expand Up @@ -2352,23 +2352,23 @@ function is_isomorphism(
end

function _as_localized_quotient(R::MPolyRing)
result = MPolyQuoLocalizedRing(R, ideal(R, elem_type(R)[]), powers_of_element(one(R)))
result = MPolyQuoLocRing(R, ideal(R, elem_type(R)[]), powers_of_element(one(R)))
iso = hom(R, result, gens(result), check=false)
iso_inv = hom(result, R, gens(R), check=false)
return result, iso, iso_inv
end

function _as_localized_quotient(A::MPolyQuoRing)
R = base_ring(A)
result = MPolyQuoLocalizedRing(R, modulus(A), powers_of_element(one(R)))
result = MPolyQuoLocRing(R, modulus(A), powers_of_element(one(R)))
iso = hom(A, result, gens(result), check=false)
iso_inv = hom(result, A, gens(R), check=false)
return result, iso, iso_inv
end

function _as_localized_quotient(L::MPolyLocRing)
R = base_ring(L)
result = MPolyQuoLocalizedRing(R, ideal(R, elem_type(R)[]), inverted_set(L))
result = MPolyQuoLocRing(R, ideal(R, elem_type(R)[]), inverted_set(L))
iso = hom(L, result, gens(result), check=false)
iso_inv = hom(result, L, gens(R), check=false)
return result, iso, iso_inv
Expand Down
4 changes: 4 additions & 0 deletions src/aliases.jl
Original file line number Diff line number Diff line change
Expand Up @@ -55,3 +55,7 @@ function number_of_vertices end
@alias nroots number_of_roots
@alias nsimpleroots number_of_simple_roots
@alias nvertices number_of_vertices

# these are kept for compatibility with Graphs.jl / GraphsBase.jl
@alias ne number_of_edges
@alias nv number_of_vertices
Loading

0 comments on commit d9ff9dc

Please sign in to comment.