remove deprecations from 0.14.0 and before #3358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
these functions were deprecated in #2980 (long before 0.14.0) but slightly in the wrong location in the file
lgoettgens
approved these changes
Feb 13, 2024
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #3358 +/- ##
==========================================
+ Coverage 81.82% 82.06% +0.24%
==========================================
Files 556 556
Lines 74385 74258 -127
==========================================
+ Hits 60867 60942 +75
+ Misses 13518 13316 -202
|
ooinaruhugh
pushed a commit
to ooinaruhugh/Oscar.jl
that referenced
this pull request
Feb 15, 2024
* remove deprecations from 0.14.0 and before * remove more old deprecations these functions were deprecated in oscar-system#2980 (long before 0.14.0) but slightly in the wrong location in the file * re-add ne and nv alias * remove obsolete exports * fix deprecated usage of MPolyQuoLocalizedRing -> MPolyQuoLocRing * add explanation for ne and nv
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re-add
nvandnealiases.As a draft for now, also to see if CI did miss some errors (e.g. due to #3143).
x-ref: #3356