Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecations from 0.14.0 and before #3358

Merged
merged 6 commits into from
Feb 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Rings/mpolyquo-localizations.jl
Original file line number Diff line number Diff line change
Expand Up @@ -2352,23 +2352,23 @@
end

function _as_localized_quotient(R::MPolyRing)
result = MPolyQuoLocalizedRing(R, ideal(R, elem_type(R)[]), powers_of_element(one(R)))
result = MPolyQuoLocRing(R, ideal(R, elem_type(R)[]), powers_of_element(one(R)))

Check warning on line 2355 in src/Rings/mpolyquo-localizations.jl

View check run for this annotation

Codecov / codecov/patch

src/Rings/mpolyquo-localizations.jl#L2355

Added line #L2355 was not covered by tests
iso = hom(R, result, gens(result), check=false)
iso_inv = hom(result, R, gens(R), check=false)
return result, iso, iso_inv
end

function _as_localized_quotient(A::MPolyQuoRing)
R = base_ring(A)
result = MPolyQuoLocalizedRing(R, modulus(A), powers_of_element(one(R)))
result = MPolyQuoLocRing(R, modulus(A), powers_of_element(one(R)))
iso = hom(A, result, gens(result), check=false)
iso_inv = hom(result, A, gens(R), check=false)
return result, iso, iso_inv
end

function _as_localized_quotient(L::MPolyLocRing)
R = base_ring(L)
result = MPolyQuoLocalizedRing(R, ideal(R, elem_type(R)[]), inverted_set(L))
result = MPolyQuoLocRing(R, ideal(R, elem_type(R)[]), inverted_set(L))
iso = hom(L, result, gens(result), check=false)
iso_inv = hom(result, L, gens(R), check=false)
return result, iso, iso_inv
Expand Down
4 changes: 4 additions & 0 deletions src/aliases.jl
Original file line number Diff line number Diff line change
Expand Up @@ -55,3 +55,7 @@ function number_of_vertices end
@alias nroots number_of_roots
@alias nsimpleroots number_of_simple_roots
@alias nvertices number_of_vertices

# these are kept for compatibility with Graphs.jl / GraphsBase.jl
@alias ne number_of_edges
@alias nv number_of_vertices
Loading
Loading