Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Accessibility workflow #81

Merged
merged 3 commits into from
Dec 12, 2023
Merged

Add Accessibility workflow #81

merged 3 commits into from
Dec 12, 2023

Conversation

jpmckinney
Copy link
Member

@jpmckinney jpmckinney commented Dec 12, 2023

closes #80

Change
- Hide navbar behind sandwich toggle
- Move display utility from SVG to parent, to hide logo on small screens to make room for sandwich toggle
- Use JS from Boostrap 5

Preserve
- Restore form-inline to reproduce existing behavior
- Preserve current max-width by removing xxl container
- Preserve no underline in extension sidebar
- Add dropdown menu padding to restore active checkmark position

CSS selector updates
- margin and padding: l(eft) -> s(tart), r(ight) -> e(nd)
- thead-light -> table-light
- font-italic -> fst-italic
- custom-select -> form-select
- badge-pill -> rounded-pill
- badge-light -> text-bg-light
- data-toggle -> data-bs-toggle
- data-target -> data-bs-target
- align-items-center is included

Other
- Add aria-label for Extension URL, Toggle navigation, Select language
- Use single quotes for translations of HTML attribute values to improve code highlighting
…translate "Extension URL" and "Toggle navigation" (update "Toggle extension navigation").
@coveralls
Copy link

coveralls commented Dec 12, 2023

Pull Request Test Coverage Report for Build 7177746264

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.991%

Changes Missing Coverage Covered Lines Changed/Added Lines %
extension_explorer/util.py 0 1 0.0%
Totals Coverage Status
Change from base Build 7118300852: 0.0%
Covered Lines: 431
Relevant Lines: 449

💛 - Coveralls

@jpmckinney jpmckinney merged commit 1e472ca into main Dec 12, 2023
9 checks passed
@jpmckinney jpmckinney deleted the pa11y branch December 12, 2023 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add pa11y workflow
2 participants