Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Accessibility workflow #81

Merged
merged 3 commits into from
Dec 12, 2023
Merged

Add Accessibility workflow #81

merged 3 commits into from
Dec 12, 2023

Commits on Dec 12, 2023

  1. css: Update Bootstrap files to 5.2.3

    @jpmckinney
    jpmckinney committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    1b0da87 View commit details
    Browse the repository at this point in the history

  2. Update templates to Bootstrap 5 

    Change
- Hide navbar behind sandwich toggle
- Move display utility from SVG to parent, to hide logo on small screens to make room for sandwich toggle
- Use JS from Boostrap 5

Preserve
- Restore form-inline to reproduce existing behavior
- Preserve current max-width by removing xxl container
- Preserve no underline in extension sidebar
- Add dropdown menu padding to restore active checkmark position

CSS selector updates
- margin and padding: l(eft) -> s(tart), r(ight) -> e(nd)
- thead-light -> table-light
- font-italic -> fst-italic
- custom-select -> form-select
- badge-pill -> rounded-pill
- badge-light -> text-bg-light
- data-toggle -> data-bs-toggle
- data-target -> data-bs-target
- align-items-center is included

Other
- Add aria-label for Extension URL, Toggle navigation, Select language
- Use single quotes for translations of HTML attribute values to improve code highlighting
    @jpmckinney
    jpmckinney committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    494f67c View commit details
    Browse the repository at this point in the history

  3. fix: Fix accessibility issues. ci: Add a11y workflow. i18n: Manually … 

    …translate "Extension URL" and "Toggle navigation" (update "Toggle extension navigation").
    @jpmckinney
    jpmckinney committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    1fbf744 View commit details
    Browse the repository at this point in the history