Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade grpc client #16

Merged
merged 5 commits into from
Apr 8, 2024
Merged

chore: upgrade grpc client #16

merged 5 commits into from
Apr 8, 2024

Conversation

alxckn
Copy link
Contributor

@alxckn alxckn commented Apr 7, 2024

This PR

  • Update the gRPC client code using latest published version
  • Upgrade gems (fixes an issue where first flag evaluation would take 15-20 seconds, didn't look any further given the upgrade seems to have fixed the problem)
  • Add tests against an actual flagd server
  • Fix an simplify client code

@alxckn
Update protobuf
136b49e 
Signed-off-by: Alexandre Chakroun <achakroun@macmail.fr>
@alxckn
Regenerate client, upgrade gems and make code more explicit
f0c9a5c 
Signed-off-by: Alexandre Chakroun <achakroun@macmail.fr>
@alxckn
Test against flagd server
07179c3 
Signed-off-by: Alexandre Chakroun <achakroun@macmail.fr>
@alxckn
Add flagd container to CI
3e460ec 
Signed-off-by: Alexandre Chakroun <achakroun@macmail.fr>
@alxckn
run docker container in background
b427f87 
missing health checks?

Signed-off-by: Alexandre Chakroun <achakroun@macmail.fr>
@alxckn alxckn changed the title Update protobuf chore: upgrade grpc client Apr 7, 2024
maxveldink
maxveldink approved these changes Apr 8, 2024
View reviewed changes
Copy link
Member

@maxveldink maxveldink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not very familiar with FlagD, but I don't see any issues on the Ruby side here 👍🏻 Thanks for the contribution(s)!

@beeme1mr beeme1mr merged commit 23ed78a into open-feature:main Apr 8, 2024
3 of 4 checks passed
@openfeaturebot openfeaturebot mentioned this pull request May 1, 2024
Merged
beeme1mr pushed a commit that referenced this pull request May 16, 2024
@openfeaturebot
chore(main): release openfeature-flagd-provider 0.1.0 (#27)
3efbd68 
🤖 I have created a release *beep* *boop*
---


##
[0.1.0](openfeature-flagd-provider-v0.0.1...openfeature-flagd-provider/v0.1.0)
(2024-05-16)


### ⚠ BREAKING CHANGES

* update flagd name and grpc schema
([#30](#30))

### ✨ New Features

* Add flagd provider
([#2](#2))
([98b695b](98b695b))
* Add support for unix socket path and secure connection
([#8](#8))
([88436c7](88436c7))
* Flagd provider uses structs from sdk
([#24](#24))
([d437e7f](d437e7f))
* integrate flagd provider with OpenFeature SDK
([#18](#18))
([80d6d02](80d6d02))
* Return default value on error
([#25](#25))
([f365c6d](f365c6d))
* update flagd name and grpc schema
([#30](#30))
([ddd438a](ddd438a))


### 🧹 Chore

* Format with standard
([#20](#20))
([bf25043](bf25043))
* Make things work
([#13](#13))
([5968037](5968037))
* update link to use new doc domain
([#12](#12))
([9baff65](9baff65))
* upgrade grpc client
([#16](#16))
([23ed78a](23ed78a))


### 🔄 Refactoring

* OpenFeature::FlagD::Provider::Configuration
([#14](#14))
([3686eb5](3686eb5))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beeme1mr beeme1mr beeme1mr approved these changes

@maxveldink maxveldink maxveldink approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alxckn @beeme1mr @maxveldink