Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: update flagd name and grpc schema #30

Merged
merged 8 commits into from
May 13, 2024
Merged

feat!: update flagd name and grpc schema #30

merged 8 commits into from
May 13, 2024

Conversation

beeme1mr
Copy link
Member

@beeme1mr beeme1mr commented May 1, 2024

This PR

  • updates the flagd namespace
  • updates the grpc schema

Related Issues

Fixes #7

Notes

https://flagd.dev/reference/naming/

Follow-up Tasks

Automate gRPC client generation.

@beeme1mr
update flagd name and grpc schema
f92043c 
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
@beeme1mr beeme1mr linked an issue May 1, 2024 that may be closed by this pull request
Change namespace to Flagd instead of FlagD #7
Closed
@beeme1mr
lower case flagd in docs
3b0d046 
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
@beeme1mr
skip lint check on generated files
b35945c 
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
@beeme1mr
specifiy inherit mode
d0050d7 
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
@beeme1mr
changed relative path of generated file
17ef438 
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
@beeme1mr
made import relative
ff11baa 
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
alxckn
alxckn reviewed May 2, 2024
View reviewed changes
Copy link
Contributor

@alxckn alxckn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the errors seem to stem from the replacement of schema_services_pb.rb by evaluation_services_pb.rb. To be honest, I'm not super clear on the difference between those 2, they seem to provide similar functionalities and API. Curious to know @beeme1mr if you have insights ;)

providers/openfeature-flagd-provider/lib/openfeature/flagd/provider.rb Show resolved Hide resolved
@beeme1mr
Copy link
Member Author

beeme1mr commented May 3, 2024

I see the errors seem to stem from the replacement of schema_services_pb.rb by evaluation_services_pb.rb. To be honest, I'm not super clear on the difference between those 2, they seem to provide similar functionalities and API. Curious to know @beeme1mr if you have insights ;)

I was trying to update the provider to use the new schema. The old one was poorly named and is now deprecated. Unfortunately, I haven't been able to get it working. If you have any ideas on how to fix it, please let me know :)

@alxckn
Copy link
Contributor

alxckn commented May 13, 2024

I see the errors seem to stem from the replacement of schema_services_pb.rb by evaluation_services_pb.rb. To be honest, I'm not super clear on the difference between those 2, they seem to provide similar functionalities and API. Curious to know @beeme1mr if you have insights ;)

I was trying to update the provider to use the new schema. The old one was poorly named and is now deprecated. Unfortunately, I haven't been able to get it working. If you have any ideas on how to fix it, please let me know :)

Couldn't push directly on the repo, here's a commit that should make this PR green @beeme1mr

@beeme1mr
fixed constant names to match evaluation_pb
f1fb741 
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
@beeme1mr
Copy link
Member Author

Couldn't push directly on the repo, here's a commit that should make this PR green @beeme1mr

Amazing, thank you! I've pushed your suggestions 🤞

maxveldink
maxveldink approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@maxveldink maxveldink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦑

@beeme1mr beeme1mr merged commit ddd438a into main May 13, 2024
8 checks passed
@beeme1mr beeme1mr deleted the 7-change-namespace-to-flagd-instead-of-flagd branch May 13, 2024 14:44
@openfeaturebot openfeaturebot mentioned this pull request May 13, 2024
Merged
beeme1mr pushed a commit that referenced this pull request May 16, 2024
@openfeaturebot
chore(main): release openfeature-flagd-provider 0.1.0 (#27)
3efbd68 
🤖 I have created a release *beep* *boop*
---


##
[0.1.0](openfeature-flagd-provider-v0.0.1...openfeature-flagd-provider/v0.1.0)
(2024-05-16)


### ⚠ BREAKING CHANGES

* update flagd name and grpc schema
([#30](#30))

### ✨ New Features

* Add flagd provider
([#2](#2))
([98b695b](98b695b))
* Add support for unix socket path and secure connection
([#8](#8))
([88436c7](88436c7))
* Flagd provider uses structs from sdk
([#24](#24))
([d437e7f](d437e7f))
* integrate flagd provider with OpenFeature SDK
([#18](#18))
([80d6d02](80d6d02))
* Return default value on error
([#25](#25))
([f365c6d](f365c6d))
* update flagd name and grpc schema
([#30](#30))
([ddd438a](ddd438a))


### 🧹 Chore

* Format with standard
([#20](#20))
([bf25043](bf25043))
* Make things work
([#13](#13))
([5968037](5968037))
* update link to use new doc domain
([#12](#12))
([9baff65](9baff65))
* upgrade grpc client
([#16](#16))
([23ed78a](23ed78a))


### 🔄 Refactoring

* OpenFeature::FlagD::Provider::Configuration
([#14](#14))
([3686eb5](3686eb5))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alxckn alxckn alxckn left review comments

@maxveldink maxveldink maxveldink approved these changes

@josecolella josecolella Awaiting requested review from josecolella

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change namespace to Flagd instead of FlagD
3 participants
@beeme1mr @alxckn @maxveldink