1/3 Port PDH helpers from Core #1175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-bebbington
force-pushed
the
windowsperfcounters-receiver
branch
3 times, most recently
from
e2db281
to
82b7605
Compare
james-bebbington
force-pushed
the
windowsperfcounters-receiver
branch
from
82b7605
to
7d0f544
Compare
Codecov Report
@@ Coverage Diff @@
## master #1175 +/- ##
===========================================
+ Coverage 76.01% 89.97% +13.96%
===========================================
Files 24 283 +259
Lines 1163 13772 +12609
===========================================
+ Hits 884 12391 +11507
- Misses 226 1013 +787
- Partials 53 368 +315
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
james-bebbington
force-pushed
the
windowsperfcounters-receiver
branch
2 times, most recently
from
9b00167
to
673dd9c
Compare
|
@james-bebbington would it be possible to break into 2 PRs:
|
james-bebbington
force-pushed
the
windowsperfcounters-receiver
branch
from
673dd9c
to
a51e9f3
Compare
james-bebbington
changed the title
james-bebbington
changed the title
james-bebbington
force-pushed
the
windowsperfcounters-receiver
branch
from
a51e9f3
to
2521fb2
Compare
james-bebbington
changed the title
Alright done. I updated this PR & the description so this is now (1) & #1211 is (2) |
james-bebbington
force-pushed
the
windowsperfcounters-receiver
branch
from
2521fb2
to
dbb9d58
Compare
Thank you. |
asuresh4
approved these changes
Oct 6, 2020
receiver/windowsperfcountersreceiver/internal/third_party/telegraf/win_perf_counters/LICENSE
Outdated
Show resolved
Hide resolved
james-bebbington
changed the title
bogdandrutu
approved these changes
Oct 12, 2020
tigrannajaryan
pushed a commit
that referenced
this pull request
Oct 30, 2020
…#1211) Adds skeleton for Windows Performance Counters Receiver with very basic initial functionality that can read simple counters that do not include any instance into a Gauge metric - see the added README.md for more details. **Link to tracking Issue:** #1088 Note the scaffolding code makes use of the new `receiverhelper` & `scraperhelper` functions added in the Core PRs referenced below. **Depends on:** #1175, open-telemetry/opentelemetry-collector#1886, open-telemetry/opentelemetry-collector#1890
dyladan
referenced
this pull request
in dynatrace-oss-contrib/opentelemetry-collector-contrib
Jan 29, 2021
@james-bebbington made a lot of contributions to the core collector and reviews see https://github.com/open-telemetry/opentelemetry-collector/pulls?q=is%3Apr+author%3Ajames-bebbington+is%3Aclosed+
ljmsc
referenced
this pull request
in ljmsc/opentelemetry-collector-contrib
Feb 21, 2022
* Convert XConfigure into constructor for metrics A follow up of #1155. * Add to CHANGELOG Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to tracking Issue: #1088
Description: As a precursor to creating a Windows perf counters receiver component, this PR:
pdhfrom Core (was removed from Core in 3/3 Remove third_party PDH code opentelemetry-collector#1870)win_perf_countersfrom Core (was removed from Core in 3/3 Remove third_party PDH code opentelemetry-collector#1870)See also: #1211