3/3 Remove third_party PDH code #1870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-bebbington
requested review from
bogdandrutu,
dmitryax,
nilebox,
owais,
pjanotti and
tigrannajaryan
as code owners
james-bebbington
force-pushed
the
hostmetrics-perflib-final
branch
from
586e8d3
to
84ff40b
Compare
james-bebbington
force-pushed
the
hostmetrics-perflib-final
branch
2 times, most recently
from
3580e00
to
e85eb8a
Compare
james-bebbington
force-pushed
the
hostmetrics-perflib-final
branch
2 times, most recently
from
d49863b
to
84db5ec
Compare
james-bebbington
force-pushed
the
hostmetrics-perflib-final
branch
from
84db5ec
to
d12b4dc
Compare
Codecov Report
@@ Coverage Diff @@
## master #1870 +/- ##
==========================================
+ Coverage 91.23% 91.26% +0.02%
==========================================
Files 272 272
Lines 16263 16263
==========================================
+ Hits 14838 14842 +4
+ Misses 998 996 -2
+ Partials 427 425 -2
Continue to review full report at Codecov.
|
| @@ -2,7 +2,6 @@ | |||
| # This is the code that we want to run tests for and lint, staticcheck, etc. | |||
| ALL_SRC := $(shell find . -name '*.go' \ | |||
| -not -path './testbed/*' \ | |||
| -not -path '*/third_party/*' \ | |||
There was a problem hiding this comment.
I had made any third_party directories get ignored (here and in .golangci.yaml) when I originally added this PDH code. Not sure if I should remove this or if we should keep it anyway? There seemed to be a desire to keep third party code out of core, so I've opted to remove it for now, but also happy to revert.
bogdandrutu
approved these changes
Sep 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to tracking Issue: #973
Description:
1. Add new perflib package
2. Migrate host metrics scrapers to use new package
3. Remove third_party PDH code
Depends on: #1835, #1836, #1868, #1869