Design doc #188
Closed
Design doc #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorlindsey
requested review from
Aneurysm9,
evantorrie,
jmacd,
lizthegrey and
MrAlias
as code owners
jmacd
approved these changes
Aug 6, 2020
Aneurysm9
approved these changes
Aug 7, 2020
This was referenced Aug 11, 2020
jmacd
approved these changes
Aug 13, 2020
MrAlias
approved these changes
Aug 13, 2020
|
@connorlindsey I'd say this is "Accepted", but not sure if that means it can be closed? I'll leave it up to you. |
plantfansam
referenced
this pull request
in plantfansam/opentelemetry-go-contrib
Mar 18, 2022
Since these methods are about the span itself rather than specifically *events* on the span, it makes sense to drop "events" from their names. [Closes #33]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The attached design document outlines our plan to implement a Cortex Exporter for the Go SDK. This shouldn't be merged, but is instead a request for review before we begin implementing the Exporter. Please leave comments below or in the document. Thank you!
cc @ercl @alolita