Cortex Exporter Send Pipeline #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
August 12, 2020 00:10
ercl
requested review from
Aneurysm9,
evantorrie,
jmacd,
lizthegrey and
MrAlias
as code owners
jmacd
approved these changes
Aug 12, 2020
jmacd
reviewed
Aug 12, 2020
| } | ||
| exporter := Exporter{*test.config} | ||
|
|
||
| // Create an empty Snappy-compressed message. |
There was a problem hiding this comment.
nit: I'd like to see a non-empty request and have the payload verified, but I expect you're planning that for a future PR.
There was a problem hiding this comment.
Yes, I'm planning on adding that later. Thanks for the feedback!
This was referenced Aug 12, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the pipeline for sending data to Cortex. It includes functions for converting a slice of TimeSeries to a Snappy-compressed protocol buffer message, building a HTTP request, and sending the request to Cortex. Authentication will be added in a separate PR.
The design doc for the project can be found here: #188.
cc @alolita @connorlindsey