Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default sampler to ParentOrElse(AlwaysOn) #1474

Conversation

MitchellDumovic
Copy link
Contributor

Resolves #1445 and implements the changes outlined in open-telemetry/opentelemetry-specification#728

@codecov
Copy link

codecov bot commented Jul 28, 2020

Codecov Report

Merging #1474 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1474   +/-   ##
=========================================
  Coverage     92.50%   92.50%           
  Complexity      940      940           
=========================================
  Files           117      117           
  Lines          3351     3351           
  Branches        270      270           
=========================================
  Hits           3100     3100           
  Misses          169      169           
  Partials         82       82           
Impacted Files Coverage Δ Complexity Δ
...main/java/io/opentelemetry/sdk/trace/Samplers.java 90.90% <100.00%> (ø) 13.00 <0.00> (ø)
...io/opentelemetry/sdk/trace/config/TraceConfig.java 100.00% <100.00%> (ø) 4.00 <1.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96e8523...6858c1d. Read the comment docs.

Copy link
Member

@bogdandrutu bogdandrutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would wait for the specs PR to be merged

Copy link
Member

@thisthat thisthat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bogdandrutu bogdandrutu merged commit 9c2b3e4 into open-telemetry:master Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sampling Decision is not Passed From Parent to Child
5 participants