Revisit Default Sampler and Interaction With TraceFlags #728
Labels
area:sampling
Related to trace sampling
area:sdk
Related to the SDK
priority:p2
Medium priority level
release:required-for-ga
Must be resolved before GA release, or nice to have before GA
spec:trace
Related to the specification/trace directory
Should the Default Sampler be changed from
AlwaysOn
toParentOrElse(AlwaysOn)
?The spec suggests that
AlwaysOn
is the default - currently this is not truly enforced consistently across languages:In Go (this might be a bug), the span's parent is always followed unless a different sampler is specified:
https://github.com/open-telemetry/opentelemetry-go/blob/master/sdk/trace/span.go#L394
One thing that I think adds some confusion (at least for me) here is the interaction between the sampler and the Span context's
TraceFlags
. The spec suggests thatTraceFlags
should be passed down from parent to child here, but by always sampling by default this may not actually happen in practice.The text was updated successfully, but these errors were encountered: