Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default Sampler to ParentOrElse(AlwaysOn) #960

Merged
merged 4 commits into from
Aug 4, 2020
Merged

Change default Sampler to ParentOrElse(AlwaysOn) #960

merged 4 commits into from
Aug 4, 2020

Conversation

MitchellDumovic
Copy link
Contributor

@MitchellDumovic MitchellDumovic commented Jul 29, 2020 •
edited
Loading

See open-telemetry/opentelemetry-specification#750 and associated issue open-telemetry/opentelemetry-specification#728

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@MitchellDumovic MitchellDumovic requested a review from a team July 29, 2020 23:57
codeboten
codeboten approved these changes Jul 31, 2020
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, @MitchellDumovic if you could resolve the conflict.

@MitchellDumovic MitchellDumovic force-pushed the mitchell/change-default-sampler branch from e7c2042 to c5e6368 Compare July 31, 2020 22:10
@lzchen lzchen merged commit 3143a4b into open-telemetry:master Aug 4, 2020
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this pull request Nov 1, 2020
[http] fix: use url.URL (open-telemetry#960)
1959930 
url.URL from the standard library should be used instead of the global URL which comes from the dom lib.

Signed-off-by: Naseem <naseem@transit.app>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten approved these changes

@ocelotl ocelotl ocelotl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MitchellDumovic @codeboten @ocelotl @lzchen