chore: pin unit test to node 22.6 until 22.8 is available #4957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
there is a bug in node.js v22.7 with buffers that is causing grpc exporters to fail. fix should be available in 22.8, pinning to 22.6 for now.
|
Another thought - is it worth updating the |
dyladan
approved these changes
Aug 27, 2024
Apparently they are planning to fast-track in 22.8 instead of patching 22.7. The buffer fixes got added to the 22.8 plan here. |
Merged
via the queue into
open-telemetry:main
with commit Aug 27, 2024
948496d
19 of 20 checks passed
trentm
added a commit
to trentm/opentelemetry-js
that referenced
this pull request
Sep 4, 2024
Now that Node.js 22.8 is available with a workaround (nodejs/node#54565) for the bug in 22.7 that caused 'RangeError: "length" is outside of buffer bounds' errors in exporter tests (see open-telemetry#4953), we can unpin the Node.js v22 used for unit tests. This undoes the pinning from open-telemetry#4957.
Zirak
pushed a commit
to Zirak/opentelemetry-js
that referenced
this pull request
Sep 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Failing tests on grpc exporters for latest Node 22
Short description of the changes
There is a bug in node.js v22.7 with buffers that is causing grpc exporters to fail. Fix should be available in 22.8, pinning to 22.6 for now to keep development and releases moving.