Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: unpin unit-test from 22.6 #4977

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

trentm
Copy link
Contributor

@trentm trentm commented Sep 4, 2024

Now that Node.js 22.8 is available with a workaround
(nodejs/node#54565) for the bug in 22.7 that
caused 'RangeError: "length" is outside of buffer bounds' errors in
exporter tests (see #4953),
we can unpin the Node.js v22 used for unit tests.
This undoes the pinning from #4957.

Now that Node.js 22.8 is available with a workaround
(nodejs/node#54565) for the bug in 22.7 that
caused 'RangeError: "length" is outside of buffer bounds' errors in
exporter tests (see open-telemetry#4953),
we can unpin the Node.js v22 used for unit tests.
This undoes the pinning from open-telemetry#4957.
@trentm trentm self-assigned this Sep 4, 2024
@trentm trentm requested a review from a team September 4, 2024 15:02
Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 👍

@pichlermarc pichlermarc added this pull request to the merge queue Sep 4, 2024
Merged via the queue into open-telemetry:main with commit 9d474e3 Sep 4, 2024
19 of 20 checks passed
Zirak pushed a commit to Zirak/opentelemetry-js that referenced this pull request Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants