Move _SUPPRESS_INTRUMENTATION key from instrumentation to api #2187
+0
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owais
force-pushed
the
remove-instrumentation-sdk-dep
branch
from
959a490
to
d4a1f95
Compare
owais
commented
Oct 9, 2021
opentelemetry-instrumentation/src/opentelemetry/instrumentation/utils.py
Outdated
Show resolved
Hide resolved
owais
force-pushed
the
remove-instrumentation-sdk-dep
branch
from
d4a1f95
to
54a3040
Compare
owais
force-pushed
the
remove-instrumentation-sdk-dep
branch
from
54a3040
to
494ee73
Compare
srikanthccv
approved these changes
Oct 9, 2021
owais
force-pushed
the
remove-instrumentation-sdk-dep
branch
3 times, most recently
from
582b458
to
3737ea5
Compare
|
@lzchen let's not merge this for now and wait for the release. I'd like all these related changes to go in together after the next release. |
ocelotl
approved these changes
Oct 12, 2021
|
Marking it as draft to avoid accidental merging 👍 |
This will continue to be part of the internal API but live in the API context package.
owais
force-pushed
the
remove-instrumentation-sdk-dep
branch
from
3737ea5
to
24444b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This will continue to be part of the internal API but live in the API
context package.
Fixes #2184
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Contrib Repo Change?
Checklist: