Move BaseConfigurator to SDK #2188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owais
force-pushed
the
remove-private-configurator-from-sdk
branch
5 times, most recently
from
6e6ce67
to
57033f5
Compare
owais
changed the title
12 tasks
ocelotl
approved these changes
Oct 12, 2021
|
Converting to draft to avoid any accidental merge 👍 |
lzchen
approved these changes
Oct 12, 2021
This will continue to be part of the internal API but live in the API context package.
This allows SDK to not depend on instrumentation package anymore.
owais
force-pushed
the
remove-private-configurator-from-sdk
branch
from
57033f5
to
2253aea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This allows the SDK to ditch dependency on opentelemetry-instrumentation. Distro authors will still be able to use BaseConfigurator class by importing it from the SDK. As part of config refactor, we could end up removing the class completely or re-work/move it to another package.
Fixes #2184
Depends on #2187 so please review after that is merged
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Contrib Repo Change?
Checklist: