-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: move SpanKind
display format impl to jaeger
#758
api: move SpanKind
display format impl to jaeger
#758
Conversation
This format implementation is jaeger specific and not defined in the otel spec.
Codecov Report
@@ Coverage Diff @@
## main #758 +/- ##
=======================================
Coverage 70.22% 70.22%
=======================================
Files 108 108
Lines 8804 8804
=======================================
Hits 6183 6183
Misses 2621 2621
Continue to review full report at Codecov.
|
Is there a downside if we keep this in the APIs? I feel like this can be an implementation detail to help ppl build their implementation using the APIs. |
I don't think we should keep this, it seems pretty arbitrary and the Debug impl should be enough for most people. |
This format implementation is jaeger specific and not defined in the otel spec.
Some notable changes: - Upgrade to latest tracing/openteletetry dependencies: - opentelemetry 0.18.0 - opentelemetry-otlp 0.11.0 - opentelemetry-semantic-conventions 0.10.0 - tracing-opentelemetry 0.18.0 - Due to updates in opentelemetry-api dropping some Display trait implementations some changes had to be made to preserve the string representations (in one case static strings is used, and in another case a wrapping unit type is used to ship a similar Display impl) References: open-telemetry/opentelemetry-rust#758 References: tokio-rs/tracing#1218 Signed-off-by: Fletcher Nichol <fletcher@systeminit.com>
Some notable changes: - Upgrade to latest tracing/openteletetry dependencies: - opentelemetry 0.18.0 - opentelemetry-otlp 0.11.0 - opentelemetry-semantic-conventions 0.10.0 - tracing-opentelemetry 0.18.0 - Due to updates in opentelemetry-api dropping some Display trait implementations some changes had to be made to preserve the string representations (in one case static strings is used, and in another case a wrapping unit type is used to ship a similar Display impl) References: open-telemetry/opentelemetry-rust#758 References: tokio-rs/tracing#1218 Signed-off-by: Fletcher Nichol <fletcher@systeminit.com>
1295: build(deps): update Rust dependencies (2022-W39) r=nickgerace a=fnichol Some notable changes: - Upgrade to latest tracing/openteletetry dependencies: - opentelemetry 0.18.0 - opentelemetry-otlp 0.11.0 - opentelemetry-semantic-conventions 0.10.0 - tracing-opentelemetry 0.18.0 - Due to updates in opentelemetry-api dropping some Display trait implementations some changes had to be made to preserve the string representations (in one case static strings is used, and in another case a wrapping unit type is used to ship a similar Display impl) - The `protoc` (i.e. Protobuf compiler) is now required on build/ci/development systems due to updates with the tonic Rust crate References: open-telemetry/opentelemetry-rust#758 References: tokio-rs/tracing#1218 Co-authored-by: Fletcher Nichol <fletcher@systeminit.com>
Some notable changes: - Upgrade to latest tracing/openteletetry dependencies: - opentelemetry 0.18.0 - opentelemetry-otlp 0.11.0 - opentelemetry-semantic-conventions 0.10.0 - tracing-opentelemetry 0.18.0 - Due to updates in opentelemetry-api dropping some Display trait implementations some changes had to be made to preserve the string representations (in one case static strings is used, and in another case a wrapping unit type is used to ship a similar Display impl) References: open-telemetry/opentelemetry-rust#758 References: tokio-rs/tracing#1218 Signed-off-by: Fletcher Nichol <fletcher@systeminit.com>
1295: build(deps): update Rust dependencies (2022-W39) r=fnichol a=fnichol Some notable changes: - Upgrade to latest tracing/openteletetry dependencies: - opentelemetry 0.18.0 - opentelemetry-otlp 0.11.0 - opentelemetry-semantic-conventions 0.10.0 - tracing-opentelemetry 0.18.0 - Due to updates in opentelemetry-api dropping some Display trait implementations some changes had to be made to preserve the string representations (in one case static strings is used, and in another case a wrapping unit type is used to ship a similar Display impl) - The `protoc` (i.e. Protobuf compiler) is now required on build/ci/development systems due to updates with the tonic Rust crate References: open-telemetry/opentelemetry-rust#758 References: tokio-rs/tracing#1218 Co-authored-by: Fletcher Nichol <fletcher@systeminit.com>
This format implementation is jaeger specific and not defined in the otel spec.