-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): update Rust dependencies (2022-W39) #1295
Conversation
👷 Deploy request for system-init-corp pending review.A Netlify team Owner will need to approve the deploy before you can run your build. Are you a team Owner? Visit the deploys page to approve it → Need more help? Learn more in the Netlify docs →
|
This change should help when new system package dependenencies are added to know what is new/changed. Since this script explicitly asks for `bash`, variables are safely allowed ;) Signed-off-by: Fletcher Nichol <fletcher@systeminit.com>
1af6a17
to
94e8ac0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -25,7 +25,7 @@ default--check-lint: | |||
## check-doc: Checks all documentation for the Rust crate | |||
default--check-doc: | |||
$(call header,$@) | |||
env RUSTDOCFLAGS="-Dwarnings" cargo doc --all | |||
env RUSTDOCFLAGS="-Dwarnings" cargo doc --all-features --no-deps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NICE! This will help a lot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it was causing CI to fail otherwise because a crate was using a nightly-only cfg for rustdoc, oi!
bors merge |
1295: build(deps): update Rust dependencies (2022-W39) r=nickgerace a=fnichol Some notable changes: - Upgrade to latest tracing/openteletetry dependencies: - opentelemetry 0.18.0 - opentelemetry-otlp 0.11.0 - opentelemetry-semantic-conventions 0.10.0 - tracing-opentelemetry 0.18.0 - Due to updates in opentelemetry-api dropping some Display trait implementations some changes had to be made to preserve the string representations (in one case static strings is used, and in another case a wrapping unit type is used to ship a similar Display impl) - The `protoc` (i.e. Protobuf compiler) is now required on build/ci/development systems due to updates with the tonic Rust crate References: open-telemetry/opentelemetry-rust#758 References: tokio-rs/tracing#1218 Co-authored-by: Fletcher Nichol <fletcher@systeminit.com>
Build failed: |
Ah yes, I need to account for @nickgerace I'll add this to the PR then test with a bors test before I know it's all good then can merge it, thanks for the eyes! |
This program is now required via versions of the tonic crate which is pulled into the OpenTelemetry family of Rust crates. Signed-off-by: Fletcher Nichol <fletcher@systeminit.com>
This change updates a few strategies all of which reduce check time and false positive failures: - Remove `--all` flag which is deprecated for `--workspace` and is not the intended default behavior at a component/crate level (i.e. only check documentation for _this_ crate) - Add `--all-features` to ensure that all feature-gated code documentation is also checked - Add `--no-deps` flag which does not check documentation for dependencies Signed-off-by: Fletcher Nichol <fletcher@systeminit.com>
Some notable changes: - Upgrade to latest tracing/openteletetry dependencies: - opentelemetry 0.18.0 - opentelemetry-otlp 0.11.0 - opentelemetry-semantic-conventions 0.10.0 - tracing-opentelemetry 0.18.0 - Due to updates in opentelemetry-api dropping some Display trait implementations some changes had to be made to preserve the string representations (in one case static strings is used, and in another case a wrapping unit type is used to ship a similar Display impl) References: open-telemetry/opentelemetry-rust#758 References: tokio-rs/tracing#1218 Signed-off-by: Fletcher Nichol <fletcher@systeminit.com>
94e8ac0
to
55641ba
Compare
Tested image builds locally and looks good bors merge |
Build succeeded:
|
Some notable changes:
implementations some changes had to be made to preserve the string
representations (in one case static strings is used, and in another
case a wrapping unit type is used to ship a similar Display impl)
protoc
(i.e. Protobuf compiler) is now required on build/ci/developmentsystems due to updates with the tonic Rust crate
References: open-telemetry/opentelemetry-rust#758
References: tokio-rs/tracing#1218