Skip to content

Commit

Permalink
Remove semantic convention automation from Specification repository. (#…
Browse files Browse the repository at this point in the history
…3501)

Removes semantic convention automation and programmatic pieces now that
semantic conventions reside in a separate repository:

https://github.com/open-telemetry/semantic-conventions

Related [OTEP(s)](https://github.com/open-telemetry/oteps)
[#227](https://github.com/open-telemetry/oteps/blob/main/text/0227-separate-semantic-conventions.md)
  • Loading branch information
jsuereth authored May 12, 2023
1 parent b0a2268 commit 279e5e1
Show file tree
Hide file tree
Showing 59 changed files with 5 additions and 4,640 deletions.
14 changes: 0 additions & 14 deletions .github/workflows/checks.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -82,17 +82,3 @@ jobs:

- name: run docfx
run: docfx build --dry-run

semantic-conventions:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v1
- name: verify semantic convention tables
run: make table-check

schemas-check:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v1
- name: verify schemas
run: make schema-check
35 changes: 0 additions & 35 deletions .github/workflows/publish-schemas.yml

This file was deleted.

5 changes: 0 additions & 5 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -90,11 +90,6 @@ See:
- [Misspell Check](#misspell-check)
- Markdown link checking (docs TODO)

### Semantic Conventions update

Semantic convention is declared in YAML files and markdown tables are
generated from these files. Read about semantic convention updates [here](./semantic_conventions/README.md).

### Autoformatting

The Specification has some autogenerated components and additionally can do
Expand Down
20 changes: 2 additions & 18 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ SEMCONVGEN_VERSION=0.17.0

# TODO: add `yamllint` step to `all` after making sure it works on Mac.
.PHONY: all
all: install-tools markdownlint markdown-link-check misspell table-check schema-check
all: install-tools markdownlint markdown-link-check misspell

$(MISSPELL):
cd $(TOOLS_DIR) && go build -o $(MISSPELL_BINARY) github.com/client9/misspell/cmd/misspell
Expand Down Expand Up @@ -71,30 +71,14 @@ install-yamllint:
yamllint:
yamllint .

# Generate markdown tables from YAML definitions
.PHONY: table-generation
table-generation:
docker run --rm -v $(PWD)/semantic_conventions:/source -v $(PWD)/specification:/spec \
otel/semconvgen:$(SEMCONVGEN_VERSION) -f /source markdown -md /spec

# Check if current markdown tables differ from the ones that would be generated from YAML definitions
.PHONY: table-check
table-check:
docker run --rm -v $(PWD)/semantic_conventions:/source -v $(PWD)/specification:/spec \
otel/semconvgen:$(SEMCONVGEN_VERSION) -f /source markdown -md /spec --md-check

.PHONY: schema-check
schema-check:
$(TOOLS_DIR)/schema_check.sh

# Run all checks in order of speed / likely failure.
.PHONY: check
check: misspell markdownlint markdown-link-check
@echo "All checks complete"

# Attempt to fix issues / regenerate tables.
.PHONY: fix
fix: table-generation misspell-correction
fix: misspell-correction
@echo "All autofixes complete"

.PHONY: install-tools
Expand Down
66 changes: 0 additions & 66 deletions internal/tools/schema_check.sh

This file was deleted.

46 changes: 0 additions & 46 deletions semantic_conventions/README.md

This file was deleted.

38 changes: 0 additions & 38 deletions semantic_conventions/client.yaml

This file was deleted.

41 changes: 0 additions & 41 deletions semantic_conventions/deprecated/http.yaml

This file was deleted.

Loading

0 comments on commit 279e5e1

Please sign in to comment.