Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove semantic convention automation from Specification repository. #3501

Merged
merged 6 commits into from
May 12, 2023

Conversation

jsuereth
Copy link
Contributor

@jsuereth jsuereth commented May 11, 2023

Removes semantic convention automation and programmatic pieces now that semantic conventions reside in a separate repository:

https://github.com/open-telemetry/semantic-conventions

Related OTEP(s) #0227

@jsuereth jsuereth marked this pull request as ready for review May 11, 2023 21:46
@jsuereth jsuereth requested review from a team May 11, 2023 21:46
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @jsuereth I think it would make sense to add a changelog entry for 1.21.0 release "Semantic conventions have moved from this repository to https://github.com/open-telemetry/semantic-conventions"

.github/workflows/checks.yaml Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
@carlosalberto
Copy link
Contributor

When we are ready to merge, we will need to manually disable the schemas-check/semantic-conventions checks in our main branch protection rules.

specification/overview.md Outdated Show resolved Hide resolved
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
@carlosalberto
Copy link
Contributor

We should probably do a follow-up to triple check outdated notes, but otherwise we are ready to go!

@carlosalberto carlosalberto merged commit 279e5e1 into open-telemetry:main May 12, 2023
@jsuereth jsuereth deleted the pr-remove-semconv-checks branch May 12, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants