Introduce "Scope full name" for backwards compatibility #2780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
IMHO, with this, we just shift the breakage to the instrumentations. Now, adding any attribute to the scope, or changing its value changes the identity of the scope and is a (potentially) breaking change. |
|
Can you explain the "breakage"? I don't see any breakage. |
|
I meant "breakage" as in "breaking change". I.e., instead of making a breaking change to the spec, adding any new attribute to a scope is a breaking change for the instrumentation that does it. And it is also harder to group scopes by their actual name now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2762
Changes
This requires producers to include Scope Attributes in the Scope "full name", which uses the same encoding as HTTP
User-Agentto include multiple key-values with optional comments. This addresses the backwards-compatibility problem with Scope Attributes by ensuring that the full name uniquely (and redundantly) specifies the scope attributes.