Clarify that Scope attributes are not part of its identity #2794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves open-telemetry#2762 This change says that Scope attributes are NOT part of the Tracer/Meter/Logger identity. The consequence of this change is the following: - It is no longer possible to obtain a Logger with different sets of attributes from the same instrumentation library (using the same name, version,schema_url). It may be desirable to make this possible in the future, but right now it is impossible since the attributes are not part of the Scope's identity. - Likewise, it is no longer possible to obtain a Tracer and Meter with different sets of attributes from the same instrumentation library (using the same name, version,schema_url). This is likely the only desirable way for Tracer and Meter.
|
Duplicate of #2789 |
|
Closed in favour of #2789 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2762
This change says that Scope attributes are NOT part of the Tracer/Meter/Logger identity.
The consequence of this change is the following:
It is no longer possible to obtain a Logger with different sets of attributes from the same instrumentation library (using the same name, version,schema_url). It may be desirable to make this possible in the future, but right now it is impossible since the attributes are not part of the Scope's identity.
Likewise, it is no longer possible to obtain a Tracer and Meter with different sets of attributes from the same instrumentation library (using the same name, version,schema_url). This is likely the only desirable way for Tracer and Meter.
This is an alternate to draft #2780