Add section to clarify pluralization rules #3641
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
mx-psi
approved these changes
Aug 4, 2023
|
cc @open-telemetry/specs-semconv-approvers |
jsuereth
reviewed
Aug 9, 2023
| @@ -64,6 +64,13 @@ Names SHOULD follow these rules: | |||
| and the value type SHOULD be an array. E.g. `process.command_args` might include multiple | |||
| values: the executable name and command arguments. | |||
|
|
|||
| - An exception to the above can occur when the attribute name in the plural form conflicts | |||
| with another possible meaning. For example, using `host.ip` instead of `host.ips` is preferred | |||
There was a problem hiding this comment.
Wouldn't this be better as host.ip_addresses then?
There was a problem hiding this comment.
Please comment on open-telemetry/semantic-conventions#203 (comment), so far we have discussed the following possibilities:
host.ip.addresseshost.iphost.socket.address
with no consensus
There was a problem hiding this comment.
This addition is mostly to reflect the arguments shared at open-telemetry/semantic-conventions#203 (comment). But yes let's keep the conversation at that PR.
|
semi-related: #3658 |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a section in the Name Pluralization guidelines to clarify an exception for using the plural form as this was discussed at open-telemetry/semantic-conventions#203 (comment).
@mx-psi @MikePaquette @AlexanderWert feel free to have a look and suggest anything here.