Metric names and namespaces should not be pluralized #3658
Closed
+7
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
force-pushed
the
metric-name-and-namespace-pluralization
branch
from
9768547
to
676a5ee
Compare
trask
force-pushed
the
metric-name-and-namespace-pluralization
branch
from
676a5ee
to
683ff02
Compare
3 tasks
jsuereth
approved these changes
Aug 15, 2023
reyang
reviewed
Aug 15, 2023
Co-authored-by: Reiley Yang <reyang@microsoft.com>
reyang
approved these changes
Aug 15, 2023
|
@jsuereth @reyang I'm moving this PR to draft. I think the PR bites off too much. I think I'm going to send instead a PR only about metric namespaces first, since that is a less impactful change (and addresses the original issue open-telemetry/semantic-conventions#212). I'll open a new issue to discuss applying this to metric names also, as that will affect lots of Counter metrics, and I don't think it's immediately clear how we would rename these:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes open-telemetry/semantic-conventions#212
Changes
Metric names and namespaces should not be pluralized.