fix: delete manifest before blobs by default #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchincha
requested review from
dmcgowan,
jzelinskie,
jonjohnsonjr,
jdolitsky,
mikebrow,
stevvooe,
sudo-bmitch and
vbatts
as code owners
rchincha
force-pushed
the
delete-manifest
branch
4 times, most recently
from
6473769
to
1124f18
Compare
mikebrow
previously requested changes
Jun 15, 2023
There was a problem hiding this comment.
looking good
can you update the readme to explain this change...
https://github.com/opencontainers/distribution-spec/blame/main/conformance/README.md#L34
something to the effect that the default if the env is not set has changed...
rchincha
force-pushed
the
delete-manifest
branch
from
1124f18
to
632489f
Compare
Fixed. |
Currently the conformance tests default to deleting manifests after blobs, which leaves the manifest dangling. Furthermore, the same blob may be referenced in many manifests. AFAIK, no client does this. So changing default behavior. Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>
rchincha
force-pushed
the
delete-manifest
branch
from
632489f
to
88f2730
Compare
jdolitsky
previously approved these changes
Jun 21, 2023
jdolitsky
reviewed
Jun 21, 2023
Signed-off-by: Josh Dolitsky <393494+jdolitsky@users.noreply.github.com>
jdolitsky
approved these changes
Jun 21, 2023
jonjohnsonjr
approved these changes
Jun 21, 2023
sudo-bmitch
pushed a commit
to sudo-bmitch/distribution-spec
that referenced
this pull request
Aug 18, 2023
* fix: delete manifest before blobs by default Currently the conformance tests default to deleting manifests after blobs, which leaves the manifest dangling. Furthermore, the same blob may be referenced in many manifests. AFAIK, no client does this. So changing default behavior. Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com> * Update conformance/README.md Signed-off-by: Josh Dolitsky <393494+jdolitsky@users.noreply.github.com> --------- Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com> Signed-off-by: Josh Dolitsky <393494+jdolitsky@users.noreply.github.com> Co-authored-by: Josh Dolitsky <393494+jdolitsky@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.