Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for Comments for v1.1.0 release #1093

Closed
sajayantony opened this issue Jul 6, 2023 · 19 comments
Closed

Request for Comments for v1.1.0 release #1093

sajayantony opened this issue Jul 6, 2023 · 19 comments
Milestone

Comments

@sajayantony
Copy link
Member

This issue serves as a tracking mechanism for collecting feedback from clients or registry operators.

The primary objective of this issue is to allow implementors to provide their input and opinions within a tentative six-week time frame. During this period, implementors are encouraged to raise any blocking comments or issues related to the proposed changes. These comments and issues will be logged and monitored under the v1.1.0 Milestone.

Additionally, project maintainers and stakeholders are invited to show their support by providing a "Thumbs up" or an LGTM (Looks Good to Me) comment, indicating their endorsement for specific proposals. Such expressions of support are valuable for prioritizing and evaluating the importance of the proposed changes.

Please note that the duration of the six-week time frame is subject to adjustment. Any feedback or issues not explicitly tracked under the milestone will be considered for the subsequent milestone unless the maintainers agree to include them in the v1.1.0 milestone.

/cc @opencontainers/image-spec-maintainers

@sajayantony sajayantony added this to the v1.1.0 milestone Jul 6, 2023
@jdolitsky
Copy link
Member

download

@rchincha
Copy link

rchincha commented Jul 6, 2023

Thanks @sajayantony

"The primary objective of this issue is to allow implementors to provide their input and opinions within a tentative six-week time frame. During this period, implementors are encouraged to raise any blocking comments or issues related to the proposed changes. These comments and issues will be logged and monitored under the v1.1.0 Milestone."

^ glad that we are refining the process - greatly improves ability to plan around OCI deliverables.

@rchincha
Copy link

rchincha commented Jul 6, 2023

Speaking for zot project, artifacts support already merged into 2.0.0-rc5 and index support merged into main branch. We will cut another -rc release shortly.

@sudo-bmitch
Copy link
Contributor

Putting on my regclient hat for a moment:

I've added support for this in regclient and I'm just looking for registries to test the new distribution-spec APIs against and other clients to verify interoperability.

@northtyphoon
Copy link

For Azure Container Registry, the support for v1.1 RC3 has been rolled out worldwide on all Azure clouds. We are currently testing RC4 and will release it very soon.

@ChristianKniep
Copy link

Is there a condensed write-up of what changes with v1.1?

@shizhMSFT
Copy link
Contributor

oras-go has released v2.2.1 with image-spec dependency bumped up to v1.1.0-rc4. Since oras-go has integrated v1.1.0-rc1 and v1.1.0-rc2 previously in its stable releases, oras-go will fully implement v1.1.0-rc4 with maximum backward compatibility for v1.1.0-rc1 and v1.1.0-rc2. This effort is tracked in oras-project/oras-go#494 and is picked up by @Wwwsylvia. The compatibility for RC versions of image-spec is planned to be dropped in oras-go v3.

Since oras CLI depends on oras-go, the current releases of oras supports image-spec v1.1.0-rc2. The oras CLI will support v1.1.0-rc4 once oras-go has fully implemented it. /cc @qweeah

@jdolitsky
Copy link
Member

Is there a condensed write-up of what changes with v1.1?

Not that I'm aware of. We should put this together and publish on the OCI blog: https://opencontainers.org/posts/blog/

Maybe people can share here any posts they have which describe the changes. This post I wrote a bit ago details the effect of these changes on a specific client (cosign): https://www.chainguard.dev/unchained/building-towards-oci-v1-1-support-in-cosign

@jdolitsky
Copy link
Member

I've just opened this PR to add a blog post to outline the upcoming changes in image-spec & distribution-spec v1.1: opencontainers/opencontainers.org#130

Maintainers - please help review and let me know if this reflects your understanding of the major changes and how to communicate them.

@milosgajdos
Copy link

At Docker Hub we are taking a more conservative approach after the last pre-stable release debacle. We did have a preliminary implementation of RC1/RC2 ready to be released at the beginning of this year, but we will be a bit more cautious with the v1.1 rollout when it comes to it.

We don't agree with every change to be released in the v1.1 spec, nevertheless, once the stable release is cut we will do our best to comply with it.

@sudo-bmitch
Copy link
Contributor

Thanks @milosgajdos. Are there specific parts of the spec that may not get implemented by Docker Hub? And are there changes we should consider before the GA?

@milosgajdos
Copy link

We are not saying we will not implement some changes - not at the moment, anyway. We're saying we'll approach the implementation of the stable release with caution.

@jdolitsky
Copy link
Member

Please see this blog post for a summary of the upcoming changes in image-spec & distribution-spec: https://opencontainers.org/posts/blog/2023-07-07-summary-of-upcoming-changes-in-oci-image-and-distribution-specs-v-1-1/

@rchincha
Copy link

rchincha commented Jul 31, 2023

Registry support for upcoming 1.1.0 OCI dist-spec/image-spec (OCI "artifacts" support)

Registry Supported Release version (or) pending PR
zot yes 2.0.0-rc6 (working config)

Client tools

Client tool Supported Release version (or) pending PR
regclient yes 0.5.0

@shizhMSFT
Copy link
Contributor

The main branch of oras-go is up to date with image-spec v1.1.0-rc4 and distribution-spec v1.1.0-rc3 by @Wwwsylvia. Those changes are planned to be published in the next v2.3.0 release in early August.

oras CLI is being updated with the latest oras-go by @qweeah and the next stable release v1.1.0 is planned around mid-August.

@avtakkar
Copy link

avtakkar commented Aug 25, 2023

At Azure Container Registry, adding to @northtyphoon 's previous comment, we did internal testing and don't have any issue with the current RC4 version of the spec besides allowing an index without artifact type (#1106).

Edit: From a registry perspective, there is no concern to support a referrer artifact without an artifactType.

@sajayantony
Copy link
Member Author

At this point from my side I see no blocking issue on image spec but there is a possible update on distribution to releax the artifact type requirement. Currently #1109 is in preparation for v1.1.0 is in draft .

@shizhMSFT
Copy link
Contributor

oras-go v2.3.0 and oras v1.1.0 are released and are compliant with image-spec v1.1.0-rc4 and distribution-spec v1.1.0-rc3.

@sajayantony
Copy link
Member Author

Closing this as there are no more outstanding items for release of v1.1 of image spec.
All future items are targeted towards v1.2 milestone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants