remove Transifex calls for OEP-58 #887
Conversation
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @hopewise! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Makefile
Outdated
| # Pulls translations from Transifex. | ||
| pull_translations: | ||
| tx pull -t -f --mode reviewed --languages=$(transifex_langs) | ||
| else | ||
| # Experimental: OEP-58 Pulls translations using atlas |
There was a problem hiding this comment.
Please remove this comment.
When this pull request is merged, OEP-58 is no longer experimental.
| # Experimental: OEP-58 Pulls translations using atlas |
Makefile
Outdated
| @@ -1,6 +1,4 @@ | |||
| export TRANSIFEX_RESOURCE = frontend-app-account | |||
There was a problem hiding this comment.
| export TRANSIFEX_RESOURCE = frontend-app-account |
This is no longer needed.
hopewise
force-pushed
the
samir/frontend-app-account
branch
3 times, most recently
from
c12bb47
to
ce8e7b7
Compare
|
Thanks @hopewise. We need to add one more item before we can conclude this PR:
|
|
Thanks for posting the test results @hopewise: https://gist.github.com/hopewise/9b395e29af53a97e3724f48a76603394 The commit message should have the prefix |
hopewise
force-pushed
the
samir/frontend-app-account
branch
3 times, most recently
from
3c77124
to
00be345
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #887 +/- ##
==========================================
+ Coverage 56.53% 56.55% +0.02%
==========================================
Files 118 117 -1
Lines 2457 2456 -1
Branches 654 654
==========================================
Hits 1389 1389
+ Misses 997 996 -1
Partials 71 71 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Looks great. Thanks @hopewise.
Let's wait for the openedx/wg-translations#20 to be approved before making this as ready for merge.
itsjeyd
added
the
blocked by other work
itsjeyd
removed
the
blocked by other work
OmarIthawi
force-pushed
the
samir/frontend-app-account
branch
from
00be345
to
d97c6a3
Compare
|
@itsjeyd @timmc-edx @brian-smith-tcril this one is ready for merge. |
|
@hopewise 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Breaking change!
This change breaks the Jenkins transifex integration which has been deprecated in favor of the new GitHub Transifex App integration as part of OEP-58.
Changes
tx pullandtx pushcommands from the micro-frontend in favorof the
atlas pullcommand..jsonfiles will be committed into the repos.src/i18n/index.jsshould export and empty array so themake pull_translationsoverride it with the dynamic list of languages.OPENEDX_ATLAS_PULLflag to makeatlas pullthe default.Makefiletargets and other files.Test results
make pull_translationsworks as expected.make pull_translations test results
Merge timeline
This should only be merged after Translation Infrastructure update OEP-58 is fully implemented.
The timing announcement will be shared by @brian-smith-tcril on #translations-project-fc-0012 Open edX Slack channel.
Keep this pull request as a draft to prevent accidental merge.
Pre-merge checklist
References
This contribution is part of the FC-0012 project which is sparked by the Translation Infrastructure update OEP-58.
Up-to-date project overview and details are available in the Approach Memo and Technical Discovery: Translations Infrastructure Implementation document.
Join the conversation on Open edX Slack #translations-project-fc-0012.
Check the links above for full information about the overall project.