Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove Transifex calls for OEP-58 for discussion MFE #682

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

sundasnoreen12
Copy link
Contributor

INF-1279
Similar to 887

Description

Changes

  1. Removes all direct use of tx pull and tx push commands from the micro-frontend in favor of the atlas pull command.
  2. Remove source and language translations from the repositories, hence no .json files will be committed into the repos.
  3. src/i18n/index.js should export and empty array so the make pull_translations override it with the dynamic list of languages.
  4. Remove the experimental OPENEDX_ATLAS_PULL flag to make atlas pull the default.
  5. Remove all Transifex related Makefile targets and other files.

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Sandbox, if applicable.
  • Is there adequate test coverage for your changes?

Post-merge Checklist

  • Deploy the changes to prod after verifying on stage or ask @openedx/edx-infinity to do it.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.82%. Comparing base (1a2068d) to head (cb6d336).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #682   +/-   ##
=======================================
  Coverage   92.82%   92.82%           
=======================================
  Files         158      158           
  Lines        3331     3331           
  Branches      919      919           
=======================================
  Hits         3092     3092           
  Misses        219      219           
  Partials       20       20           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants