Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Add deprecation warnings #11682

Merged
merged 4 commits into from
May 11, 2020
Merged

Add deprecation warnings #11682

merged 4 commits into from
May 11, 2020

Conversation

vorot93
Copy link

@vorot93 vorot93 commented May 5, 2020

See #11681.

@vorot93 vorot93 requested review from niklasad1 and dvdplm May 9, 2020 00:51
@vorot93 vorot93 changed the title Add light client deprecation warning Add deprecation warnings May 9, 2020
@vorot93 vorot93 mentioned this pull request May 9, 2020
Open
@vorot93 vorot93 added A0-pleasereview 🤓 Pull request needs code review. B9-blocker 🚧 This pull request blocks the next release from happening. Use only in extreme cases. labels May 9, 2020
niklasad1
niklasad1 reviewed May 9, 2020
View reviewed changes
Copy link
Collaborator

@niklasad1 niklasad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I would prefer if we could have a link to the private transaction deprecation in the warning (I really like how rust is doing that). Perhaps a separate deprecation issue for private transaction too?

@vorot93
Copy link
Author

vorot93 commented May 10, 2020

@niklasad1 done

niklasad1
niklasad1 approved these changes May 11, 2020
View reviewed changes
Copy link
Collaborator

@niklasad1 niklasad1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@wesrer wesrer self-requested a review May 11, 2020 11:50
@vorot93 vorot93 merged commit 7875b78 into master May 11, 2020
@vorot93 vorot93 deleted the vorot93/deprecate-light branch May 11, 2020 11:51
dvdplm added a commit that referenced this pull request May 13, 2020
@dvdplm
Merge branch 'master' into dp/chore/upgrade-to-rocksdb-0.14
a269d4d 
* master:
  Add 3.0.0 changelog (#11690)
  Fix typo (#11698)
  Add deprecation warnings (#11682)
  Add Curl to Docker image (#11687)
  v3 release version strings and track stable (#11680)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wesrer wesrer wesrer approved these changes

@niklasad1 niklasad1 niklasad1 approved these changes

@dvdplm dvdplm Awaiting requested review from dvdplm

Assignees
No one assigned
Labels
A0-pleasereview 🤓 Pull request needs code review. B9-blocker 🚧 This pull request blocks the next release from happening. Use only in extreme cases.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vorot93 @wesrer @niklasad1