This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Add Curl to Docker image #11687
Merged
Add Curl to Docker image #11687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the alpine docker image. This is needed for creating proper healthy and readiness checks in environments like Kubernetes clusters.
eduadiez
approved these changes
May 7, 2020
ordian
approved these changes
May 7, 2020
vorot93
approved these changes
May 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realised that with the current docker image, it's not possible to add binaries afterwards due to the permissions of the image, that's good but it complicates monitoring.
In kubernetes you can create healthy and readiness checks for containers by doing HTTP requests or checking some command executions, in the case of ethereum nodes, sometimes is a bit complex because: What's a healthy node?
We handle that in Gnosis by comparing nodes to another nodes and checking synching/peer/block statuses, for that end curl is a handy library.
I tried to make a workaround to not include curl in the image, but it doesn't work 100%, it makes the job for readiness checks, but not for health checks (those have to be at the same container level).
I'm adding a new version number so we keep the history properly in the tags and docker releases at https://hub.docker.com/u/openethereum