Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add tests for importing taxonomies #225

Merged
merged 21 commits into from
Nov 23, 2023
Merged

feat: add tests for importing taxonomies #225

merged 21 commits into from
Nov 23, 2023

Conversation

diivi
Copy link
Member

@diivi diivi commented Feb 9, 2023

What

  • Add some more tests for importing/uploading taxonomies

@diivi diivi changed the title Add tests feat: add tests Feb 9, 2023
@diivi diivi changed the title feat: add tests feat: add tests for importing taxonomies Feb 9, 2023
@diivi diivi requested a review from alexgarel February 9, 2023 16:23
alexgarel
alexgarel requested changes Feb 9, 2023
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, still you really have to have tests run in isolation.

backend/tests/conftest.py Outdated Show resolved Hide resolved
backend/tests/data/test.txt Show resolved Hide resolved
backend/tests/test_api.py Outdated Show resolved Hide resolved
backend/tests/test_api.py Show resolved Hide resolved
backend/tests/test_api.py Outdated Show resolved Hide resolved
@alexgarel
Copy link
Member

@diivi, FYI, @perierc will try to finish this PR :-)

@alexgarel alexgarel mentioned this pull request Oct 26, 2023
Closed
@alexgarel
Copy link
Member

@perierc you don't need to use rebase, as normally we squash merge PRs at the end. So better use simple "merge" in the PR (easier to follow changes).

@perierc perierc self-assigned this Nov 9, 2023
@perierc
Copy link
Contributor

perierc commented Nov 9, 2023

I've added a test for the loading and dumping scripts and made them work in Docker.
However the scripts work for the test-neo4j.json file that seems to have an outdated structure, but the dump does not work with the test taxonomy that can be imported from the UI.
I have to update the scripts to make them match the new taxonomy structure.

@teolemon teolemon linked an issue Nov 16, 2023 that may be closed by this pull request
Command to import some test data in setup-dev.md outdated #262
Closed
@perierc perierc marked this pull request as ready for review November 16, 2023 22:18
@perierc perierc requested a review from a team as a code owner November 16, 2023 22:18
alexgarel
alexgarel approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great !

@alexgarel alexgarel merged commit bad3f6a into main Nov 23, 2023
7 checks passed
@alexgarel alexgarel deleted the add-tests branch November 23, 2023 16:37
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request Nov 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perierc perierc perierc left review comments

@alexgarel alexgarel alexgarel approved these changes

Assignees

@diivi diivi

@perierc perierc

Labels
api backend dependencies 🐳 Docker docker
Projects
Taxonomy-editor - CentraleSupelec 2023
Status: History
🧬 Taxonomy editor - gsoc 2022
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Command to import some test data in setup-dev.md outdated
3 participants
@diivi @alexgarel @perierc