fix(daoRegistry): extension removal (#525)

If an extension is removed from the registry, it does not need to delete it from the inverseExtensions mapping. Otherwise the register won't know that the extension was already added once. The idea is that extensions can't be re-added.
openlawteam · Mar 17, 2022 · cf45c6f · cf45c6f
1 parent 7dd3471
commit cf45c6f
Show file tree

Hide file tree

Showing 4 changed files with 624 additions and 141 deletions.
diff --git a/contracts/core/DaoRegistry.sol b/contracts/core/DaoRegistry.sol
@@ -415,7 +415,7 @@ contract DaoRegistry is MemberGuard, AdapterGuard {
         require(extensionId != bytes32(0), "extension id must not be empty");
         require(
             extensions[extensionId] == address(0x0),
-            "extension Id already in use"
+            "extensionId already in use"
         );
         require(
             !inverseExtensions[address(extension)].deleted,
@@ -441,7 +441,6 @@ contract DaoRegistry is MemberGuard, AdapterGuard {
         ExtensionEntry storage extEntry = inverseExtensions[extensionAddress];
         extEntry.deleted = true;
         //slither-disable-next-line mapping-deletion
-        delete inverseExtensions[extensionAddress];
         delete extensions[extensionId];
         emit ExtensionRemoved(extensionId);
     }
@@ -564,7 +563,7 @@ contract DaoRegistry is MemberGuard, AdapterGuard {
 
         require(
             proposal.adapterAddress == msg.sender,
-            "only the adapter that submitted the proposal can process it"
+            "only the adapter that submitted the proposal can sponsor it"
         );
 
         require(

diff --git a/test/core/daofactory.test.js → test/core/dao-factory.test.js b/test/core/daofactory.test.js → test/core/dao-factory.test.js