Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dao-registry): extension removal #525

Merged
merged 2 commits into from
Mar 17, 2022
Merged

fix(dao-registry): extension removal #525

merged 2 commits into from
Mar 17, 2022

Conversation

fforbeck
Copy link
Contributor

@fforbeck fforbeck commented Mar 16, 2022

Proposed Changes

  • If an extension is removed from the registry, it does not need to delete it from the inverseExtensions mapping. Otherwise the register won't know that the extension was already added once. The idea is that extensions can't be re-added.
  • Improved the tests for DaoRegistry.sol

@fforbeck fforbeck added the fix important fix label Mar 16, 2022
@fforbeck fforbeck requested a review from adridadou March 16, 2022 17:42
@fforbeck fforbeck changed the title fix(daoRegistry): extension removal fix(dao-registry): extension removal Mar 16, 2022
@fforbeck fforbeck closed this Mar 16, 2022
@fforbeck fforbeck reopened this Mar 16, 2022
@codecov
Copy link

codecov bot commented Mar 16, 2022

Codecov Report

Merging #525 (e592453) into master (340856f) will increase coverage by 0.26%.
The diff coverage is n/a.

❗ Current head e592453 differs from pull request most recent head 42f4998. Consider uploading reports for the commit 42f4998 to get more accurate results

@@            Coverage Diff             @@
##           master     #525      +/-   ##
==========================================
+ Coverage   84.38%   84.64%   +0.26%     
==========================================
  Files          52       52              
  Lines        1857     1856       -1     
  Branches      433      433              
==========================================
+ Hits         1567     1571       +4     
+ Misses        290      285       -5     
Impacted Files Coverage Δ
contracts/core/DaoRegistry.sol 89.08% <ø> (+2.22%) ⬆️
contracts/guards/MemberGuard.sol 100.00% <0.00%> (+7.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7dd3471...42f4998. Read the comment docs.

@fforbeck fforbeck merged commit cf45c6f into master Mar 17, 2022
@fforbeck fforbeck deleted the trb-37 branch March 17, 2022 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix important fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants