Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dao-registry): extension removal #525

Merged
merged 2 commits into from
Mar 17, 2022
Merged

fix(dao-registry): extension removal #525

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
46f13e5
fix(daoRegistry): extension removal
fforbeck Mar 16, 2022
42f4998
Merge branch 'master' into trb-37
fforbeck Mar 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions contracts/core/DaoRegistry.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,7 +415,7 @@ contract DaoRegistry is MemberGuard, AdapterGuard {
require(extensionId != bytes32(0), "extension id must not be empty");
require(
extensions[extensionId] == address(0x0),
"extension Id already in use"
"extensionId already in use"
);
require(
!inverseExtensions[address(extension)].deleted,
Expand All @@ -441,7 +441,6 @@ contract DaoRegistry is MemberGuard, AdapterGuard {
ExtensionEntry storage extEntry = inverseExtensions[extensionAddress];
extEntry.deleted = true;
//slither-disable-next-line mapping-deletion
delete inverseExtensions[extensionAddress];
delete extensions[extensionId];
emit ExtensionRemoved(extensionId);
}
Expand Down Expand Up @@ -564,7 +563,7 @@ contract DaoRegistry is MemberGuard, AdapterGuard {

require(
proposal.adapterAddress == msg.sender,
"only the adapter that submitted the proposal can process it"
"only the adapter that submitted the proposal can sponsor it"
);

require(
Expand Down
0 test/core/daofactory.test.js → test/core/dao-factory.test.js
View file
Open in desktop
File renamed without changes.
Loading