Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload translog.ckp file data as metadata to translog.tlog file for s3 remote store #13206

Closed

Conversation

skumawat2025
Copy link
Contributor

@skumawat2025 skumawat2025 commented Apr 15, 2024

Description

This PR include below changes -

  1. upload translog.ckp file data as object metadata of translog.tlog file for s3 remote storage.
  2. changes for translog download flow. Including mixed indexes that might have translog file in remote (tlog + ckp) and (tlog with metadata).

Related Issues

Resolves

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added enhancement Enhancement or improvement to existing feature or request Storage:Performance v2.14.0 labels Apr 15, 2024
Copy link
Contributor

❌ Gradle check result for e375bd1: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 4b25a94: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Apr 15, 2024

Compatibility status:

Checks if related components are compatible with change 84c8649

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/performance-analyzer.git]

Copy link
Contributor

❌ Gradle check result for d046e97: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for fd90f53: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 39bceaf: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for cdeef37:

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

…3 remote store

Signed-off-by: Sandeep Kumawat <2025sandeepkumawat@gmail.com>
…ion (opensearch-project#13179)


---------

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
Copy link
Contributor

❌ Gradle check result for 84c8649: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

shourya035 and others added 9 commits April 16, 2024 09:30
… docrep shard copies during failover (opensearch-project#13159)

Signed-off-by: Shourya Dutta Biswas <114977491+shourya035@users.noreply.github.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Peter Nied <petern@amazon.com>
Co-authored-by: Peter Nied <petern@amazon.com>
…roject#13080)

Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
Signed-off-by: Peter Nied <petern@amazon.com>
)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
…ta upload

Signed-off-by: Sandeep Kumawat <2025sandeepkumawat@gmail.com>
Copy link
Contributor

❕ Gradle check result for c56cf29: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.cluster.coordination.AwarenessAttributeDecommissionIT.testConcurrentDecommissionAction

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Apr 16, 2024

Codecov Report

Attention: Patch coverage is 44.79167% with 53 lines in your changes are missing coverage. Please review.

Project coverage is 71.48%. Comparing base (b15cb0c) to head (c56cf29).
Report is 190 commits behind head on main.

❗ Current head c56cf29 differs from pull request most recent head b22a58d. Consider uploading reports for the commit b22a58d to get more accurate results

Files Patch % Lines
...dex/translog/transfer/TranslogTransferManager.java 40.67% 32 Missing and 3 partials ⚠️
...ex/translog/transfer/BlobStoreTransferService.java 20.00% 11 Missing and 1 partial ⚠️
...ensearch/index/translog/transfer/FileSnapshot.java 69.23% 3 Missing and 1 partial ⚠️
...va/org/opensearch/repositories/s3/S3BlobStore.java 0.00% 1 Missing ⚠️
...g/opensearch/common/blobstore/FetchBlobResult.java 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #13206      +/-   ##
============================================
+ Coverage     71.42%   71.48%   +0.06%     
- Complexity    59978    60684     +706     
============================================
  Files          4985     5040      +55     
  Lines        282275   285463    +3188     
  Branches      40946    41340     +394     
============================================
+ Hits         201603   204065    +2462     
- Misses        63999    64494     +495     
- Partials      16673    16904     +231     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

reta and others added 11 commits April 16, 2024 15:31
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
* WIP on CHANGELOG-3.0 cleanup

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Cleanup CHANGELOG-3.0

Signed-off-by: Craig Perkins <cwperx@amazon.com>

---------

Signed-off-by: Craig Perkins <cwperx@amazon.com>
…eplicating (opensearch-project#13248)

This test is flaky because it is incorrectly passing a checkpoint with a higher primary term on the second invocation.
This will cancel the first replication and start another.  The test sometimes passes because it is only asserting on processLatestReceivedCheckpoint.
If the cancellation quickly completes before attempting second replication event the test will fail, otherwise it will pass.

Fixed this test by ensuring the pterm is the same, but the checkpoint is ahead.  Also added assertion that replication is not started with the exact ahead checkpoint
instead of only processLatestReivedCheckpoint. Tests already exist for ahead primary term "testShardAlreadyReplicating_HigherPrimaryTermReceived".

Signed-off-by: Marc Handalian <marc.handalian@gmail.com>
…pensearch-project#12812)

* Snapshot _status API to return correct status for partial snapshots

Signed-off-by: aggarwalShivani <shivani.aggarwal@nokia.com>

* Updated CHANGELOG.md

Signed-off-by: aggarwalShivani <shivani.aggarwal@nokia.com>

* Updated test case

Signed-off-by: aggarwalShivani <shivani.aggarwal@nokia.com>

* Setting snapshot status to SUCCESS for older versions for bwc

Signed-off-by: aggarwalShivani <shivani.aggarwal@nokia.com>

* Setting snapshot status to SUCCESS for older versions for bwc

Signed-off-by: aggarwalShivani <shivani.aggarwal@nokia.com>

* Moved BWC change to SnapshotsInProgress.java for partial snapshots

Signed-off-by: aggarwalShivani <shivani.aggarwal@nokia.com>

* Fix for flaky test testSnapshotStatusOnPartialSnapshot

Signed-off-by: aggarwalShivani <shivani.aggarwal@nokia.com>

* Updated the testcases to reuse existing getSnapshotStatus() method

Signed-off-by: aggarwalShivani <shivani.aggarwal@nokia.com>

* Fixed formatting issues detected in spotlessJavaCheck

Signed-off-by: aggarwalShivani <shivani.aggarwal@nokia.com>

* Moved the entry to CHANGELOG.md

Signed-off-by: aggarwalShivani <shivani.aggarwal@nokia.com>

---------

Signed-off-by: aggarwalShivani <shivani.aggarwal@nokia.com>
Signed-off-by: aggarwalShivani <39588384+aggarwalShivani@users.noreply.github.com>
…3225)

Signed-off-by: Ashish Singh <ssashish@amazon.com>
…13054)

* Disable stackTrace in MockSpanData by default

Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com>

* enabled MockTelemetryPlugin for ITs

Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com>

* Added the flag as system property

Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com>

* Applied java spotless check

Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com>

* Added details in changelog

Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com>

* Added details in TESTING.md

Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com>

* Update TESTING.md

Signed-off-by: Atharva Sharma <60044988+atharvasharma61@users.noreply.github.com>

---------

Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com>
Signed-off-by: Atharva Sharma <60044988+atharvasharma61@users.noreply.github.com>
…earch-project#13213)

* Update google dependencies in repository-gcs and discovery-gce

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Add to CHANGELOG

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Fix test errors and mimic repository-gcs

Signed-off-by: Craig Perkins <cwperx@amazon.com>

---------

Signed-off-by: Craig Perkins <cwperx@amazon.com>
…te upload

Signed-off-by: Sandeep Kumawat <2025sandeepkumawat@gmail.com>
Copy link
Contributor

❌ Gradle check result for 84f9c92:

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

reta and others added 6 commits April 17, 2024 14:12
…update version) (opensearch-project#13262)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
…3 remote store

Signed-off-by: Sandeep Kumawat <2025sandeepkumawat@gmail.com>
…ta upload

Signed-off-by: Sandeep Kumawat <2025sandeepkumawat@gmail.com>
…te upload

Signed-off-by: Sandeep Kumawat <2025sandeepkumawat@gmail.com>
Signed-off-by: Sandeep Kumawat <2025sandeepkumawat@gmail.com>
@skumawat2025 skumawat2025 deleted the storage-13094 branch April 17, 2024 21:09
Copy link
Contributor

❌ Gradle check result for b22a58d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request Storage:Performance v2.14.0
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.